add linting (and some initial fixes)

1 files changed, 74 insertions, 0 deletions

diff --git a/node_modules/tslint/lib/rules/noMisusedNewRule.js b/node_modules/tslint/lib/rules/noMisusedNewRule.js
new file mode 100644
index 000000000..51f34e5f4
--- /dev/null
+++ b/node_modules/tslint/lib/rules/noMisusedNewRule.js
@@ -0,0 +1,74 @@
+"use strict";
+/**
+ * @license
+ * Copyright 2017 Palantir Technologies, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+var tslib_1 = require("tslib");
+var tsutils_1 = require("tsutils");
+var ts = require("typescript");
+var Lint = require("../index");
+var Rule = (function (_super) {
+    tslib_1.__extends(Rule, _super);
+    function Rule() {
+        return _super !== null && _super.apply(this, arguments) || this;
+    }
+    Rule.prototype.apply = function (sourceFile) {
+        return this.applyWithFunction(sourceFile, walk);
+    };
+    return Rule;
+}(Lint.Rules.AbstractRule));
+/* tslint:disable:object-literal-sort-keys */
+Rule.metadata = {
+    ruleName: "no-misused-new",
+    description: "Warns on apparent attempts to define constructors for interfaces or `new` for classes.",
+    optionsDescription: "Not configurable.",
+    options: null,
+    optionExamples: [true],
+    type: "functionality",
+    typescriptOnly: true,
+};
+/* tslint:enable:object-literal-sort-keys */
+Rule.FAILURE_STRING_INTERFACE = "Interfaces cannot be constructed, only classes. Did you mean `declare class`?";
+Rule.FAILURE_STRING_CLASS = '`new` in a class is a method named "new". Did you mean `constructor`?';
+exports.Rule = Rule;
+function walk(ctx) {
+    return ts.forEachChild(ctx.sourceFile, function cb(node) {
+        if (tsutils_1.isMethodSignature(node)) {
+            if (tsutils_1.getPropertyName(node.name) === "constructor") {
+                ctx.addFailureAtNode(node, Rule.FAILURE_STRING_INTERFACE);
+            }
+        }
+        else if (tsutils_1.isMethodDeclaration(node)) {
+            if (node.body === undefined &&
+                tsutils_1.getPropertyName(node.name) === "new" &&
+                returnTypeMatchesParent(node.parent, node)) {
+                ctx.addFailureAtNode(node, Rule.FAILURE_STRING_CLASS);
+            }
+        }
+        else if (tsutils_1.isConstructSignatureDeclaration(node)) {
+            if (returnTypeMatchesParent(node.parent, node)) {
+                ctx.addFailureAtNode(node, Rule.FAILURE_STRING_INTERFACE);
+            }
+        }
+        return ts.forEachChild(node, cb);
+    });
+}
+function returnTypeMatchesParent(parent, decl) {
+    if (parent.name === undefined || decl.type === undefined || !tsutils_1.isTypeReferenceNode(decl.type)) {
+        return false;
+    }
+    return decl.type.typeName.kind === ts.SyntaxKind.Identifier && decl.type.typeName.text === parent.name.text;
+}