remove superfluous rollback, insert rollback() before shutdown just for being nice

This commit is contained in:
Christian Grothoff 2018-08-18 13:32:53 +02:00
parent 7fb43dd2ae
commit f283782d40
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC

View File

@ -414,9 +414,6 @@ history_cb (void *cls,
{ {
GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
"Got DB soft error for commit\n"); "Got DB soft error for commit\n");
/* do we need to rollback explicitly on commit failure!? */
db_plugin->rollback (db_plugin->cls,
session);
/* reduce transaction size to reduce rollback probability */ /* reduce transaction size to reduce rollback probability */
if (2 > current_batch_size) if (2 > current_batch_size)
current_batch_size /= 2; current_batch_size /= 2;
@ -524,6 +521,8 @@ history_cb (void *cls,
if (GNUNET_DB_STATUS_HARD_ERROR == qs) if (GNUNET_DB_STATUS_HARD_ERROR == qs)
{ {
GNUNET_break (0); GNUNET_break (0);
db_plugin->rollback (db_plugin->cls,
session);
GNUNET_SCHEDULER_shutdown (); GNUNET_SCHEDULER_shutdown ();
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }