From f283782d405a165a2eeca0407619cd581c650f43 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Sat, 18 Aug 2018 13:32:53 +0200
Subject: [PATCH] remove superfluous rollback, insert rollback() before
 shutdown just for being nice

---
 src/exchange/taler-exchange-wirewatch.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/exchange/taler-exchange-wirewatch.c b/src/exchange/taler-exchange-wirewatch.c
index 9f58b2890..4a25773f2 100644
--- a/src/exchange/taler-exchange-wirewatch.c
+++ b/src/exchange/taler-exchange-wirewatch.c
@@ -414,9 +414,6 @@ history_cb (void *cls,
     {
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
                   "Got DB soft error for commit\n");
-      /* do we need to rollback explicitly on commit failure!? */
-      db_plugin->rollback (db_plugin->cls,
-                           session);
       /* reduce transaction size to reduce rollback probability */
       if (2 > current_batch_size)
         current_batch_size /= 2;
@@ -524,6 +521,8 @@ history_cb (void *cls,
   if (GNUNET_DB_STATUS_HARD_ERROR == qs)
   {
     GNUNET_break (0);
+    db_plugin->rollback (db_plugin->cls,
+                         session);
     GNUNET_SCHEDULER_shutdown ();
     return GNUNET_SYSERR;
   }