diff options
author | Christian Grothoff <christian@grothoff.org> | 2015-01-19 21:09:47 +0100 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2015-01-19 21:09:47 +0100 |
commit | f9347d23953f771689d339b544370d3f9fdd97ba (patch) | |
tree | b0c0f3ee392b81dac99659ab7b7b2f0464b8a66a /src/mint/taler-mint-httpd_db.c | |
parent | a1f20a92a0578e63b2b5d764ac802dbe45ab08e0 (diff) |
document TODOs
Diffstat (limited to 'src/mint/taler-mint-httpd_db.c')
-rw-r--r-- | src/mint/taler-mint-httpd_db.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/mint/taler-mint-httpd_db.c b/src/mint/taler-mint-httpd_db.c index 45e6eeef..7a78f93e 100644 --- a/src/mint/taler-mint-httpd_db.c +++ b/src/mint/taler-mint-httpd_db.c @@ -13,11 +13,16 @@ You should have received a copy of the GNU General Public License along with TALER; see the file COPYING. If not, If not, see <http://www.gnu.org/licenses/> */ - /** * @file taler-mint-httpd_db.c * @brief Database access abstraction for the mint. * @author Christian Grothoff + * + * TODO: + * - actually abstract DB implementation (i.e. via plugin logic) + * - /deposit: properly check existing deposits + * - /deposit: properly perform commit (check return value) + * - /deposit: check for leaks */ #include "platform.h" #include "taler-mint-httpd_db.h" @@ -61,6 +66,7 @@ TALER_MINT_db_execute_deposit (struct MHD_Connection *connection, if (GNUNET_YES == res) { // FIXME: memory leak + // FIXME: memcmp will not actually work here if (0 == memcmp (existing_deposit, deposit, sizeof (struct Deposit))) return TALER_MINT_reply_deposit_success (connection, deposit); // FIXME: in the future, check if there's enough credits |