taler/wallet-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

wallet: fix p2p coin selection

Browse Source 
The p2p coin selection didn't work properly when all available denoms
are needed.

Thanks to Florian Jung for finding the issue and suggesting a fix.
This commit is contained in:
Florian Dold 2022-12-06 19:41:32 +01:00
parent d040c3b861
commit a1c5f00aed
No known key found for this signature in database
GPG Key ID: D2E4F00F29D02A4B
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/taler-wallet-core/src/operations/pay-peer.ts
View File

@ -191,12 +191,7 @@ export async function selectPeerCoins(
}[] = []; }[] = [];
for (const coin of coinInfos) { for (const coin of coinInfos) {
if (Amounts.cmp(amountAcc, instructedAmount) >= 0) { if (Amounts.cmp(amountAcc, instructedAmount) >= 0) {
const res: PeerCoinSelection = { break;
exchangeBaseUrl: exch.baseUrl,
coins: resCoins,
depositFees: depositFeesAcc,
};
return res;
} }
const gap = Amounts.add( const gap = Amounts.add(
coin.feeDeposit, coin.feeDeposit,
@ -217,6 +212,14 @@ export async function selectPeerCoins(
ageCommitmentProof: coin.ageCommitmentProof, ageCommitmentProof: coin.ageCommitmentProof,
}); });
} }
if (Amounts.cmp(amountAcc, instructedAmount) >= 0) {
const res: PeerCoinSelection = {
exchangeBaseUrl: exch.baseUrl,
coins: resCoins,
depositFees: depositFeesAcc,
};
return res;
}
continue; continue;
} }
return undefined; return undefined;