This commit is contained in:
Sebastian 2022-09-16 14:27:24 -03:00
parent 4b72bbd017
commit 860f10e6f0
No known key found for this signature in database
GPG Key ID: BE4FF68352439FC1
12 changed files with 821 additions and 664 deletions

View File

@ -20,8 +20,6 @@ import {
TalerCryptoInterfaceR, TalerCryptoInterfaceR,
} from "../cryptoImplementation.js"; } from "../cryptoImplementation.js";
const logger = new Logger("synchronousWorker.ts"); const logger = new Logger("synchronousWorker.ts");
/** /**

View File

@ -86,7 +86,12 @@ import {
checkDbInvariant, checkDbInvariant,
checkLogicInvariant, checkLogicInvariant,
} from "../../util/invariants.js"; } from "../../util/invariants.js";
import { OperationAttemptResult, OperationAttemptResultType, RetryTags, scheduleRetryInTx } from "../../util/retries.js"; import {
OperationAttemptResult,
OperationAttemptResultType,
RetryTags,
scheduleRetryInTx,
} from "../../util/retries.js";
import { import {
checkPaymentByProposalId, checkPaymentByProposalId,
confirmPay, confirmPay,

View File

@ -505,7 +505,7 @@ export async function createDepositGroup(
return { return {
depositGroupId: depositGroupId, depositGroupId: depositGroupId,
transactionId: makeEventId(TransactionType.Deposit, depositGroupId) transactionId: makeEventId(TransactionType.Deposit, depositGroupId),
}; };
} }

View File

@ -64,7 +64,12 @@ import {
readSuccessResponseTextOrThrow, readSuccessResponseTextOrThrow,
} from "../util/http.js"; } from "../util/http.js";
import { DbAccess, GetReadOnlyAccess } from "../util/query.js"; import { DbAccess, GetReadOnlyAccess } from "../util/query.js";
import { OperationAttemptResult, OperationAttemptResultType, RetryInfo, runOperationHandlerForResult } from "../util/retries.js"; import {
OperationAttemptResult,
OperationAttemptResultType,
RetryInfo,
runOperationHandlerForResult,
} from "../util/retries.js";
import { WALLET_EXCHANGE_PROTOCOL_VERSION } from "../versions.js"; import { WALLET_EXCHANGE_PROTOCOL_VERSION } from "../versions.js";
import { guardOperationException } from "./common.js"; import { guardOperationException } from "./common.js";

View File

@ -97,7 +97,13 @@ import {
throwUnexpectedRequestError, throwUnexpectedRequestError,
} from "../util/http.js"; } from "../util/http.js";
import { checkDbInvariant, checkLogicInvariant } from "../util/invariants.js"; import { checkDbInvariant, checkLogicInvariant } from "../util/invariants.js";
import { OperationAttemptResult, OperationAttemptResultType, RetryInfo, RetryTags, scheduleRetry } from "../util/retries.js"; import {
OperationAttemptResult,
OperationAttemptResultType,
RetryInfo,
RetryTags,
scheduleRetry,
} from "../util/retries.js";
import { spendCoins } from "../wallet.js"; import { spendCoins } from "../wallet.js";
import { getExchangeDetails } from "./exchanges.js"; import { getExchangeDetails } from "./exchanges.js";
import { getTotalRefreshCost } from "./refresh.js"; import { getTotalRefreshCost } from "./refresh.js";

View File

@ -52,7 +52,11 @@ import {
import { InternalWalletState } from "../internal-wallet-state.js"; import { InternalWalletState } from "../internal-wallet-state.js";
import { readSuccessResponseJsonOrThrow } from "../util/http.js"; import { readSuccessResponseJsonOrThrow } from "../util/http.js";
import { GetReadWriteAccess } from "../util/query.js"; import { GetReadWriteAccess } from "../util/query.js";
import { OperationAttemptResult, RetryInfo, runOperationHandlerForResult } from "../util/retries.js"; import {
OperationAttemptResult,
RetryInfo,
runOperationHandlerForResult,
} from "../util/retries.js";
import { guardOperationException } from "./common.js"; import { guardOperationException } from "./common.js";
import { createRefreshGroup, processRefreshGroup } from "./refresh.js"; import { createRefreshGroup, processRefreshGroup } from "./refresh.js";
import { internalCreateWithdrawalGroup } from "./withdraw.js"; import { internalCreateWithdrawalGroup } from "./withdraw.js";

View File

@ -52,7 +52,10 @@ import {
readSuccessResponseJsonOrThrow, readSuccessResponseJsonOrThrow,
} from "../util/http.js"; } from "../util/http.js";
import { checkDbInvariant, checkLogicInvariant } from "../util/invariants.js"; import { checkDbInvariant, checkLogicInvariant } from "../util/invariants.js";
import { OperationAttemptResult, OperationAttemptResultType } from "../util/retries.js"; import {
OperationAttemptResult,
OperationAttemptResultType,
} from "../util/retries.js";
import { makeCoinAvailable } from "../wallet.js"; import { makeCoinAvailable } from "../wallet.js";
import { updateExchangeFromUrl } from "./exchanges.js"; import { updateExchangeFromUrl } from "./exchanges.js";
import { makeEventId } from "./transactions.js"; import { makeEventId } from "./transactions.js";
@ -362,9 +365,6 @@ export async function acceptTip(
await processTip(ws, tipId); await processTip(ws, tipId);
} }
return { return {
transactionId: makeEventId( transactionId: makeEventId(TransactionType.Tip, tipId),
TransactionType.Tip, };
tipId
)
}
} }

View File

@ -93,7 +93,10 @@ import {
} from "../util/http.js"; } from "../util/http.js";
import { checkDbInvariant, checkLogicInvariant } from "../util/invariants.js"; import { checkDbInvariant, checkLogicInvariant } from "../util/invariants.js";
import { DbAccess, GetReadOnlyAccess } from "../util/query.js"; import { DbAccess, GetReadOnlyAccess } from "../util/query.js";
import { OperationAttemptResult, OperationAttemptResultType } from "../util/retries.js"; import {
OperationAttemptResult,
OperationAttemptResultType,
} from "../util/retries.js";
import { import {
WALLET_BANK_INTEGRATION_PROTOCOL_VERSION, WALLET_BANK_INTEGRATION_PROTOCOL_VERSION,
WALLET_EXCHANGE_PROTOCOL_VERSION, WALLET_EXCHANGE_PROTOCOL_VERSION,
@ -258,7 +261,7 @@ export function selectWithdrawalDenominations(
DenominationRecord.getValue(d), DenominationRecord.getValue(d),
d.fees.feeWithdraw, d.fees.feeWithdraw,
).amount; ).amount;
for (; ;) { for (;;) {
if (Amounts.cmp(remaining, cost) < 0) { if (Amounts.cmp(remaining, cost) < 0) {
break; break;
} }
@ -900,7 +903,8 @@ export async function updateWithdrawalDenoms(
denom.verificationStatus === DenominationVerificationStatus.Unverified denom.verificationStatus === DenominationVerificationStatus.Unverified
) { ) {
logger.trace( logger.trace(
`Validating denomination (${current + 1}/${denominations.length `Validating denomination (${current + 1}/${
denominations.length
}) signature of ${denom.denomPubHash}`, }) signature of ${denom.denomPubHash}`,
); );
let valid = false; let valid = false;
@ -983,7 +987,7 @@ async function queryReserve(
if ( if (
resp.status === 404 && resp.status === 404 &&
result.talerErrorResponse.code === result.talerErrorResponse.code ===
TalerErrorCode.EXCHANGE_RESERVES_STATUS_UNKNOWN TalerErrorCode.EXCHANGE_RESERVES_STATUS_UNKNOWN
) { ) {
ws.notify({ ws.notify({
type: NotificationType.ReserveNotYetFound, type: NotificationType.ReserveNotYetFound,
@ -1305,7 +1309,7 @@ export async function getExchangeWithdrawalInfo(
) { ) {
logger.warn( logger.warn(
`wallet's support for exchange protocol version ${WALLET_EXCHANGE_PROTOCOL_VERSION} might be outdated ` + `wallet's support for exchange protocol version ${WALLET_EXCHANGE_PROTOCOL_VERSION} might be outdated ` +
`(exchange has ${exchangeDetails.protocolVersion}), checking for updates`, `(exchange has ${exchangeDetails.protocolVersion}), checking for updates`,
); );
} }
} }
@ -1804,7 +1808,7 @@ export async function acceptWithdrawalFromUri(
transactionId: makeEventId( transactionId: makeEventId(
TransactionType.Withdrawal, TransactionType.Withdrawal,
existingWithdrawalGroup.withdrawalGroupId, existingWithdrawalGroup.withdrawalGroupId,
) ),
}; };
} }
@ -1862,10 +1866,7 @@ export async function acceptWithdrawalFromUri(
return { return {
reservePub: withdrawalGroup.reservePub, reservePub: withdrawalGroup.reservePub,
confirmTransferUrl: withdrawInfo.confirmTransferUrl, confirmTransferUrl: withdrawInfo.confirmTransferUrl,
transactionId: makeEventId( transactionId: makeEventId(TransactionType.Withdrawal, withdrawalGroupId),
TransactionType.Withdrawal,
withdrawalGroupId,
)
}; };
} }
@ -1920,9 +1921,6 @@ export async function createManualWithdrawal(
return { return {
reservePub: withdrawalGroup.reservePub, reservePub: withdrawalGroup.reservePub,
exchangePaytoUris: exchangePaytoUris, exchangePaytoUris: exchangePaytoUris,
transactionId: makeEventId( transactionId: makeEventId(TransactionType.Withdrawal, withdrawalGroupId),
TransactionType.Withdrawal,
withdrawalGroupId,
)
}; };
} }

File diff suppressed because it is too large Load Diff

View File

@ -14,7 +14,16 @@
GNU Taler; see the file COPYING. If not, see <http://www.gnu.org/licenses/> GNU Taler; see the file COPYING. If not, see <http://www.gnu.org/licenses/>
*/ */
import { AbsoluteTime, AmountJson, Amounts, DenominationInfo, FeeDescription, FeeDescriptionPair, TalerProtocolTimestamp, TimePoint } from "@gnu-taler/taler-util"; import {
AbsoluteTime,
AmountJson,
Amounts,
DenominationInfo,
FeeDescription,
FeeDescriptionPair,
TalerProtocolTimestamp,
TimePoint,
} from "@gnu-taler/taler-util";
/** /**
* Given a list of denominations with the same value and same period of time: * Given a list of denominations with the same value and same period of time:
@ -59,7 +68,10 @@ type PropsWithReturnType<T extends object, F> = Exclude<
* @param right list denominations @type {FeeDescription} * @param right list denominations @type {FeeDescription}
* @returns list of pairs for the same time * @returns list of pairs for the same time
*/ */
export function createDenominationPairTimeline(left: FeeDescription[], right: FeeDescription[]): FeeDescriptionPair[] { export function createDenominationPairTimeline(
left: FeeDescription[],
right: FeeDescription[],
): FeeDescriptionPair[] {
//both list empty, discarded //both list empty, discarded
if (left.length === 0 && right.length === 0) return []; if (left.length === 0 && right.length === 0) return [];
@ -69,31 +81,41 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
let ri = 0; let ri = 0;
while (li < left.length && ri < right.length) { while (li < left.length && ri < right.length) {
const currentValue = Amounts.cmp(left[li].value, right[ri].value) < 0 ? left[li].value : right[ri].value; const currentValue =
Amounts.cmp(left[li].value, right[ri].value) < 0
? left[li].value
: right[ri].value;
let ll = 0 //left length (until next value) let ll = 0; //left length (until next value)
while (li + ll < left.length && Amounts.cmp(left[li + ll].value, currentValue) === 0) { while (
ll++ li + ll < left.length &&
Amounts.cmp(left[li + ll].value, currentValue) === 0
) {
ll++;
} }
let rl = 0 //right length (until next value) let rl = 0; //right length (until next value)
while (ri + rl < right.length && Amounts.cmp(right[ri + rl].value, currentValue) === 0) { while (
rl++ ri + rl < right.length &&
Amounts.cmp(right[ri + rl].value, currentValue) === 0
) {
rl++;
} }
const leftIsEmpty = ll === 0 const leftIsEmpty = ll === 0;
const rightIsEmpty = rl === 0 const rightIsEmpty = rl === 0;
//check which start after, add gap so both list starts at the same time //check which start after, add gap so both list starts at the same time
// one list may be empty // one list may be empty
const leftStarts: AbsoluteTime = const leftStarts: AbsoluteTime = leftIsEmpty
leftIsEmpty ? { t_ms: "never" } : left[li].from; ? { t_ms: "never" }
const rightStarts: AbsoluteTime = : left[li].from;
rightIsEmpty ? { t_ms: "never" } : right[ri].from; const rightStarts: AbsoluteTime = rightIsEmpty
? { t_ms: "never" }
: right[ri].from;
//first time cut is the smallest time //first time cut is the smallest time
let timeCut: AbsoluteTime = leftStarts; let timeCut: AbsoluteTime = leftStarts;
if (AbsoluteTime.cmp(leftStarts, rightStarts) < 0) { if (AbsoluteTime.cmp(leftStarts, rightStarts) < 0) {
const ends = const ends = rightIsEmpty ? left[li + ll - 1].until : right[0].from;
rightIsEmpty ? left[li + ll - 1].until : right[0].from;
right.splice(ri, 0, { right.splice(ri, 0, {
from: leftStarts, from: leftStarts,
@ -102,11 +124,10 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
}); });
rl++; rl++;
timeCut = leftStarts timeCut = leftStarts;
} }
if (AbsoluteTime.cmp(leftStarts, rightStarts) > 0) { if (AbsoluteTime.cmp(leftStarts, rightStarts) > 0) {
const ends = const ends = leftIsEmpty ? right[ri + rl - 1].until : left[0].from;
leftIsEmpty ? right[ri + rl - 1].until : left[0].from;
left.splice(li, 0, { left.splice(li, 0, {
from: rightStarts, from: rightStarts,
@ -115,7 +136,7 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
}); });
ll++; ll++;
timeCut = rightStarts timeCut = rightStarts;
} }
//check which ends sooner, add gap so both list ends at the same time //check which ends sooner, add gap so both list ends at the same time
@ -130,7 +151,6 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
value: left[0].value, value: left[0].value,
}); });
rl++; rl++;
} }
if (AbsoluteTime.cmp(leftEnds, rightEnds) < 0) { if (AbsoluteTime.cmp(leftEnds, rightEnds) < 0) {
left.splice(li + ll, 0, { left.splice(li + ll, 0, {
@ -142,15 +162,23 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
} }
//now both lists are non empty and (starts,ends) at the same time //now both lists are non empty and (starts,ends) at the same time
while (li < left.length && ri < right.length && Amounts.cmp(left[li].value, right[ri].value) === 0) { while (
li < left.length &&
if (AbsoluteTime.cmp(left[li].from, timeCut) !== 0 && AbsoluteTime.cmp(right[ri].from, timeCut) !== 0) { ri < right.length &&
Amounts.cmp(left[li].value, right[ri].value) === 0
) {
if (
AbsoluteTime.cmp(left[li].from, timeCut) !== 0 &&
AbsoluteTime.cmp(right[ri].from, timeCut) !== 0
) {
// timeCut comes from the latest "until" (expiration from the previous) // timeCut comes from the latest "until" (expiration from the previous)
// and this value comes from the latest left or right // and this value comes from the latest left or right
// it should be the same as the "from" from one of the latest left or right // it should be the same as the "from" from one of the latest left or right
// otherwise it means that there is missing a gap object in the middle // otherwise it means that there is missing a gap object in the middle
// the list is not complete and the behavior is undefined // the list is not complete and the behavior is undefined
throw Error('one of the list is not completed: list[i].until !== list[i+1].from') throw Error(
"one of the list is not completed: list[i].until !== list[i+1].from",
);
} }
pairList.push({ pairList.push({
@ -172,21 +200,26 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
timeCut = right[ri].until; timeCut = right[ri].until;
ri++; ri++;
} }
pairList[pairList.length - 1].until = timeCut pairList[pairList.length - 1].until = timeCut;
if (li < left.length && Amounts.cmp(left[li].value, pairList[pairList.length - 1].value) !== 0) { if (
li < left.length &&
Amounts.cmp(left[li].value, pairList[pairList.length - 1].value) !== 0
) {
//value changed, should break //value changed, should break
//this if will catch when both (left and right) change at the same time //this if will catch when both (left and right) change at the same time
//if just one side changed it will catch in the while condition //if just one side changed it will catch in the while condition
break; break;
} }
} }
} }
//one of the list left or right can still have elements //one of the list left or right can still have elements
if (li < left.length) { if (li < left.length) {
let timeCut = pairList.length > 0 && Amounts.cmp(pairList[pairList.length - 1].value, left[li].value) === 0 ? pairList[pairList.length - 1].until : left[li].from; let timeCut =
pairList.length > 0 &&
Amounts.cmp(pairList[pairList.length - 1].value, left[li].value) === 0
? pairList[pairList.length - 1].until
: left[li].from;
while (li < left.length) { while (li < left.length) {
pairList.push({ pairList.push({
left: left[li].fee, left: left[li].fee,
@ -194,13 +227,17 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
from: timeCut, from: timeCut,
until: left[li].until, until: left[li].until,
value: left[li].value, value: left[li].value,
}) });
timeCut = left[li].until timeCut = left[li].until;
li++; li++;
} }
} }
if (ri < right.length) { if (ri < right.length) {
let timeCut = pairList.length > 0 && Amounts.cmp(pairList[pairList.length - 1].value, right[ri].value) === 0 ? pairList[pairList.length - 1].until : right[ri].from; let timeCut =
pairList.length > 0 &&
Amounts.cmp(pairList[pairList.length - 1].value, right[ri].value) === 0
? pairList[pairList.length - 1].until
: right[ri].from;
while (ri < right.length) { while (ri < right.length) {
pairList.push({ pairList.push({
right: right[ri].fee, right: right[ri].fee,
@ -208,12 +245,12 @@ export function createDenominationPairTimeline(left: FeeDescription[], right: Fe
from: timeCut, from: timeCut,
until: right[ri].until, until: right[ri].until,
value: right[ri].value, value: right[ri].value,
}) });
timeCut = right[ri].until timeCut = right[ri].until;
ri++; ri++;
} }
} }
return pairList return pairList;
} }
/** /**

View File

@ -243,7 +243,7 @@ export async function scheduleRetry(
return await ws.db return await ws.db
.mktx((x) => [x.operationRetries]) .mktx((x) => [x.operationRetries])
.runReadWrite(async (tx) => { .runReadWrite(async (tx) => {
tx.operationRetries tx.operationRetries;
scheduleRetryInTx(ws, tx, opId, errorDetail); scheduleRetryInTx(ws, tx, opId, errorDetail);
}); });
} }

View File

@ -42,7 +42,7 @@ export interface TimerHandle {
} }
class IntervalHandle { class IntervalHandle {
constructor(public h: any) { } constructor(public h: any) {}
clear(): void { clear(): void {
clearInterval(this.h); clearInterval(this.h);
@ -60,7 +60,7 @@ class IntervalHandle {
} }
class TimeoutHandle { class TimeoutHandle {
constructor(public h: any) { } constructor(public h: any) {}
clear(): void { clear(): void {
clearTimeout(this.h); clearTimeout(this.h);
@ -130,8 +130,6 @@ export class SetTimeoutTimerAPI implements TimerAPI {
after(delayMs: number, callback: () => void): TimerHandle { after(delayMs: number, callback: () => void): TimerHandle {
return new TimeoutHandle(setTimeout(callback, delayMs)); return new TimeoutHandle(setTimeout(callback, delayMs));
} }
} }
export const timer = new SetTimeoutTimerAPI(); export const timer = new SetTimeoutTimerAPI();
@ -146,7 +144,7 @@ export class TimerGroup {
private idGen = 1; private idGen = 1;
constructor(public readonly timerApi: TimerAPI) { } constructor(public readonly timerApi: TimerAPI) {}
stopCurrentAndFutureTimers(): void { stopCurrentAndFutureTimers(): void {
this.stopped = true; this.stopped = true;