wallet-core: make DB migration logic more tolerant

packages/taler-wallet-core/src/db.ts

@@ -2468,8 +2468,14 @@ export async function applyFixups(
   });
 }
 
+/**
+ * Upgrade an IndexedDB in an upgrade transaction.
+ *
+ * The upgrade is made based on a store map, i.e. the metadata
+ * structure that describes all the object stores and indexes.
+ */
 function upgradeFromStoreMap(
-  storeMap: any,
+  storeMap: any, // FIXME: nail down type
   db: IDBDatabase,
   oldVersion: number,
   newVersion: number,
@@ -2511,6 +2517,10 @@ function upgradeFromStoreMap(
       continue;
     }
     let s: IDBObjectStore;
+    // Be tolerant if object store already exists.
+    // Probably means somebody deployed without
+    // adding the "addedInVersion" attribute.
+    if (!upgradeTransaction.objectStoreNames.contains(swi.storeName)) {
       try {
         s = db.createObjectStore(swi.storeName, {
           autoIncrement: storeDesc.autoIncrement,
@@ -2522,12 +2532,19 @@ function upgradeFromStoreMap(
           `Migration failed. Could not create store ${swi.storeName}.${moreInfo}`,
         );
       }
+    } else {
+      s = upgradeTransaction.objectStore(swi.storeName);
+    }
     for (const indexName in swi.indexMap as any) {
       const indexDesc: IndexDescriptor = swi.indexMap[indexName];
       const indexAddedVersion = indexDesc.versionAdded ?? 0;
       if (indexAddedVersion <= oldVersion) {
         continue;
       }
+      // Be tolerant if index already exists.
+      // Probably means somebody deployed without
+      // adding the "addedInVersion" attribute.
+      if (!s.indexNames.contains(indexDesc.name)) {
         try {
           s.createIndex(indexDesc.name, indexDesc.keyPath, {
             multiEntry: indexDesc.multiEntry,
@@ -2542,6 +2559,7 @@ function upgradeFromStoreMap(
       }
     }
   }
+}
 
 function promiseFromTransaction(transaction: IDBTransaction): Promise<void> {
   return new Promise<void>((resolve, reject) => {