taler/wallet-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

hide transient errors when accepting a tip

Browse Source
This commit is contained in:
Florian Dold 2020-11-26 12:27:31 +01:00
parent c0006300cf
commit 2b19594e7a
No known key found for this signature in database
GPG Key ID: D2E4F00F29D02A4B
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/taler-wallet-core/src/operations/tip.ts
View File

@ -40,7 +40,7 @@ import { getRandomBytes, encodeCrock } from "../crypto/talerCrypto";
import { guardOperationException, makeErrorDetails } from "./errors";
import { NotificationType } from "../types/notifications";
import { getTimestampNow } from "../util/time";
import { readSuccessResponseJsonOrThrow } from "../util/http";
import { getHttpResponseErrorDetails, readSuccessResponseJsonOrThrow } from "../util/http";
import { URL } from "../util/url";
import { Logger } from "../util/logging";
import { checkDbInvariant } from "../util/invariants";
@ -132,11 +132,11 @@ export async function prepareTip(
async function incrementTipRetry(
ws: InternalWalletState,
refreshSessionId: string,
walletTipId: string,
err: TalerErrorDetails | undefined,
): Promise<void> {
await ws.db.runWithWriteTransaction([Stores.tips], async (tx) => {
const t = await tx.get(Stores.tips, refreshSessionId);
const t = await tx.get(Stores.tips, walletTipId);
if (!t) {
return;
}
@ -239,6 +239,23 @@ async function processTipImpl(
const req = { planchets: planchetsDetail };
const merchantResp = await ws.http.postJson(tipStatusUrl.href, req);
// Hide transient errors.
if (
tipRecord.retryInfo.retryCounter < 5 &&
merchantResp.status >= 500 &&
merchantResp.status <= 599
) {
const err = makeErrorDetails(
TalerErrorCode.WALLET_UNEXPECTED_REQUEST_ERROR,
"tip pickup failed (transient)",
getHttpResponseErrorDetails(merchantResp),
);
await incrementTipRetry(ws, tipRecord.walletTipId, err);
// FIXME: Maybe we want to signal to the caller that the transient error happened?
return;
}
const response = await readSuccessResponseJsonOrThrow(
merchantResp,
codecForTipResponse(),