taler/wallet-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

improve error messages in DB transactions

Browse Source
This commit is contained in:
Florian Dold 2021-07-12 15:54:25 +02:00
parent 0b854299d1
commit 2a48caa341
No known key found for this signature in database
GPG Key ID: D2E4F00F29D02A4B
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/taler-wallet-core/src/util/query.ts
View File

@ -87,6 +87,15 @@ interface CursorValueResult<T> {
value: T; value: T;
} }
class TransactionAbortedError extends Error {
constructor(m: string) {
super(m);
// Set the prototype explicitly.
Object.setPrototypeOf(this, TransactionAbortedError.prototype);
}
}
class ResultStream<T> { class ResultStream<T> {
private currentPromise: Promise<void>; private currentPromise: Promise<void>;
private gotCursorEnd = false; private gotCursorEnd = false;
@ -396,6 +405,7 @@ function runTx<Arg, Res>(
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
let funResult: any = undefined; let funResult: any = undefined;
let gotFunResult = false; let gotFunResult = false;
let transactionException: any = undefined;
tx.oncomplete = () => { tx.oncomplete = () => {
// This is a fatal error: The transaction completed *before* // This is a fatal error: The transaction completed *before*
// the transaction function returned. Likely, the transaction // the transaction function returned. Likely, the transaction
@ -416,12 +426,16 @@ function runTx<Arg, Res>(
logger.error(`${stack}`); logger.error(`${stack}`);
}; };
tx.onabort = () => { tx.onabort = () => {
let msg: string;
if (tx.error) { if (tx.error) {
logger.error("Transaction aborted with error:", tx.error); msg = `Transaction aborted (transaction error): ${tx.error}`;
} else if (transactionException !== undefined) {
msg = `Transaction aborted (exception thrown): ${transactionException}`;
} else { } else {
logger.error("Transaction aborted (no error)"); msg = "Transaction aborted (no DB error)";
} }
reject(TransactionAbort); logger.error(msg);
reject(new TransactionAbortedError(msg));
}; };
const resP = Promise.resolve().then(() => f(arg)); const resP = Promise.resolve().then(() => f(arg));
resP resP
@ -433,6 +447,7 @@ function runTx<Arg, Res>(
if (e == TransactionAbort) { if (e == TransactionAbort) {
logger.trace("aborting transaction"); logger.trace("aborting transaction");
} else { } else {
transactionException = e;
console.error("Transaction failed:", e); console.error("Transaction failed:", e);
console.error(stack); console.error(stack);
tx.abort(); tx.abort();