taler/wallet-core
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Activity

don't rip off the merchant via our coin selection

Browse Source
This commit is contained in:
Florian Dold 2020-03-27 15:20:02 +05:30
parent 5d1b0df8a4
commit 1c747ae004
No known key found for this signature in database
GPG Key ID: D2E4F00F29D02A4B
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/operations/pay.ts
View File

@ -234,11 +234,17 @@ export function selectPayCoins(
).amount; ).amount;
if (Amounts.cmp(amountActualAvailable, amountPayRemaining) > 0) { if (Amounts.cmp(amountActualAvailable, amountPayRemaining) > 0) {
// Partial spending // Partial spending, as the coin is worth more than the remaining
// amount to pay.
coinSpend = Amounts.add(amountPayRemaining, depositFeeSpend).amount; coinSpend = Amounts.add(amountPayRemaining, depositFeeSpend).amount;
// Make sure we contribute at least the deposit fee, otherwise
// contributing this coin would cause a loss for the merchant.
if (Amounts.cmp(coinSpend, aci.feeDeposit) < 0) {
coinSpend = aci.feeDeposit;
}
amountPayRemaining = Amounts.getZero(currency); amountPayRemaining = Amounts.getZero(currency);
} else { } else {
// Spend the full remaining amount // Spend the full remaining amount on the coin
coinSpend = aci.availableAmount; coinSpend = aci.availableAmount;
amountPayRemaining = Amounts.add(amountPayRemaining, depositFeeSpend) amountPayRemaining = Amounts.add(amountPayRemaining, depositFeeSpend)
.amount; .amount;