From 1728e5011e16f226c6e3675aa196872af39f6c4e Mon Sep 17 00:00:00 2001 From: Florian Dold Date: Thu, 2 Apr 2020 14:46:53 +0530 Subject: [PATCH] split reconciliation and summary of reserve history --- src/operations/reserves.ts | 1 - src/types/dbTypes.ts | 17 ++++++++--------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/operations/reserves.ts b/src/operations/reserves.ts index 2e1b487b9..5cf189d3b 100644 --- a/src/operations/reserves.ts +++ b/src/operations/reserves.ts @@ -115,7 +115,6 @@ export async function createReserve( retryInfo: initRetryInfo(), lastError: undefined, reserveTransactions: [], - history: [], }; const senderWire = req.senderWire; diff --git a/src/types/dbTypes.ts b/src/types/dbTypes.ts index c88148e7e..9c2b3ca3e 100644 --- a/src/types/dbTypes.ts +++ b/src/types/dbTypes.ts @@ -35,7 +35,13 @@ import { import { Index, Store } from "../util/query"; import { OperationError, RefreshReason } from "./walletTypes"; -import { ReserveTransaction, ReserveCreditTransaction, ReserveWithdrawTransaction, ReserveClosingTransaction, ReserveRecoupTransaction } from "./ReserveTransaction"; +import { + ReserveTransaction, + ReserveCreditTransaction, + ReserveWithdrawTransaction, + ReserveClosingTransaction, + ReserveRecoupTransaction, +} from "./ReserveTransaction"; import { Timestamp, Duration, getTimestampNow } from "../util/time"; import { Wallet } from "../wallet"; @@ -191,7 +197,7 @@ export interface WalletReserveHistoryRecoupItem { matchedExchangeTransaction?: ReserveRecoupTransaction; } -export type WalletReserveHistoryItem = +export type WalletReserveHistoryItem = | WalletReserveHistoryCreditItem | WalletReserveHistoryWithdrawItem | WalletReserveHistoryRecoupItem @@ -300,13 +306,6 @@ export interface ReserveRecord { lastError: OperationError | undefined; reserveTransactions: ReserveTransaction[]; - - /** - * History of the reserve as modeled by the wallet. - * Reconciled with the history kept by the exchange - * when we request the reserve status. - */ - history: WalletReserveHistoryItem[]; } /**