wallet-core/node_modules/tslint/lib/rules/noUnboundMethodRule.js

108 lines
6.7 KiB
JavaScript
Raw Normal View History

2017-05-28 00:38:50 +02:00
"use strict";
/**
* @license
* Copyright 2017 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Object.defineProperty(exports, "__esModule", { value: true });
var tslib_1 = require("tslib");
2017-08-14 05:01:11 +02:00
var tsutils_1 = require("tsutils");
2017-05-28 00:38:50 +02:00
var ts = require("typescript");
var Lint = require("../index");
2017-08-14 05:01:11 +02:00
var OPTION_IGNORE_STATIC = "ignore-static";
2017-10-14 18:40:54 +02:00
var Rule = /** @class */ (function (_super) {
2017-05-28 00:38:50 +02:00
tslib_1.__extends(Rule, _super);
function Rule() {
return _super !== null && _super.apply(this, arguments) || this;
}
Rule.prototype.applyWithProgram = function (sourceFile, program) {
2017-10-14 18:40:54 +02:00
return this.applyWithFunction(sourceFile, walk, {
2017-08-14 05:01:11 +02:00
ignoreStatic: this.ruleArguments.indexOf(OPTION_IGNORE_STATIC) !== -1,
2017-10-14 18:40:54 +02:00
}, program.getTypeChecker());
2017-05-28 00:38:50 +02:00
};
2017-08-14 05:01:11 +02:00
/* tslint:disable:object-literal-sort-keys */
Rule.metadata = {
ruleName: "no-unbound-method",
2018-09-20 02:56:13 +02:00
description: "Warns when a method is used outside of a method call.",
2017-08-14 05:01:11 +02:00
optionsDescription: "You may optionally pass \"" + OPTION_IGNORE_STATIC + "\" to ignore static methods.",
options: {
type: "string",
enum: [OPTION_IGNORE_STATIC],
},
optionExamples: [true, [true, OPTION_IGNORE_STATIC]],
2018-09-20 02:56:13 +02:00
rationale: Lint.Utils.dedent(templateObject_1 || (templateObject_1 = tslib_1.__makeTemplateObject(["\n Class functions don't preserve the class scope when passed as standalone variables.\n For example, this code will log the global scope (`window`/`global`), not the class instance:\n\n ```\n class MyClass {\n public log(): void {\n console.log(this);\n }\n }\n\n const instance = new MyClass();\n const log = instance.log;\n\n log();\n ```\n\n You need to either use an arrow lambda (`() => {...}`) or call the function with the correct scope.\n\n ```\n class MyClass {\n public logArrowBound = (): void => {\n console.log(bound);\n };\n\n public logManualBind(): void {\n console.log(this);\n }\n }\n\n const instance = new MyClass();\n const logArrowBound = instance.logArrowBound;\n const logManualBind = instance.logManualBind.bind(instance);\n\n logArrowBound();\n logManualBind();\n ```\n "], ["\n Class functions don't preserve the class scope when passed as standalone variables.\n For example, this code will log the global scope (\\`window\\`/\\`global\\`), not the class instance:\n\n \\`\\`\\`\n class MyClass {\n public log(): void {\n console.log(this);\n }\n }\n\n const instance = new MyClass();\n const log = instance.log;\n\n log();\n \\`\\`\\`\n\n You need to either use an arrow lambda (\\`() => {...}\\`) or call the function with the correct scope.\n\n \\`\\`\\`\n class MyClass {\n public logArrowBound = (): void => {\n console.log(bound);\n };\n\n public logManualBind(): void {\n console.log(this);\n }\n }\n\n const instance = new MyClass();\n const logArrowBound = instance.logArrowBound;\n const logManualBind = instance.logManualBind.bind(instance);\n\n logArrowBound();\n logManualBind();\n \\`\\`\\`\n "]))),
2017-08-14 05:01:11 +02:00
type: "functionality",
typescriptOnly: true,
requiresTypeInfo: true,
};
/* tslint:enable:object-literal-sort-keys */
Rule.FAILURE_STRING = "Avoid referencing unbound methods which may cause unintentional scoping of 'this'.";
2017-05-28 00:38:50 +02:00
return Rule;
}(Lint.Rules.TypedRule));
exports.Rule = Rule;
2017-08-14 05:01:11 +02:00
function walk(ctx, tc) {
return ts.forEachChild(ctx.sourceFile, function cb(node) {
if (tsutils_1.isPropertyAccessExpression(node) && !isSafeUse(node)) {
var symbol = tc.getSymbolAtLocation(node);
2017-05-28 00:38:50 +02:00
var declaration = symbol === undefined ? undefined : symbol.valueDeclaration;
2017-08-14 05:01:11 +02:00
if (declaration !== undefined && isMethod(declaration, ctx.options.ignoreStatic)) {
ctx.addFailureAtNode(node, Rule.FAILURE_STRING);
2017-05-28 00:38:50 +02:00
}
}
2017-08-14 05:01:11 +02:00
return ts.forEachChild(node, cb);
});
}
function isMethod(node, ignoreStatic) {
2017-05-28 00:38:50 +02:00
switch (node.kind) {
case ts.SyntaxKind.MethodDeclaration:
case ts.SyntaxKind.MethodSignature:
2017-08-14 05:01:11 +02:00
return !(ignoreStatic && tsutils_1.hasModifier(node.modifiers, ts.SyntaxKind.StaticKeyword));
2017-05-28 00:38:50 +02:00
default:
return false;
}
}
function isSafeUse(node) {
var parent = node.parent;
switch (parent.kind) {
case ts.SyntaxKind.CallExpression:
return parent.expression === node;
case ts.SyntaxKind.TaggedTemplateExpression:
return parent.tag === node;
2018-09-20 02:56:13 +02:00
// E.g. `obj.method.bind(obj) or obj.method["prop"]`.
2017-05-28 00:38:50 +02:00
case ts.SyntaxKind.PropertyAccessExpression:
2018-09-20 02:56:13 +02:00
case ts.SyntaxKind.ElementAccessExpression:
2017-05-28 00:38:50 +02:00
return true;
// Allow most binary operators, but don't allow e.g. `myArray.forEach(obj.method || otherObj.otherMethod)`.
case ts.SyntaxKind.BinaryExpression:
return parent.operatorToken.kind !== ts.SyntaxKind.BarBarToken;
2017-08-14 05:01:11 +02:00
case ts.SyntaxKind.NonNullExpression:
case ts.SyntaxKind.AsExpression:
case ts.SyntaxKind.TypeAssertionExpression:
case ts.SyntaxKind.ParenthesizedExpression:
return isSafeUse(parent);
// Allow use in conditions
case ts.SyntaxKind.ConditionalExpression:
return parent.condition === node;
case ts.SyntaxKind.IfStatement:
case ts.SyntaxKind.WhileStatement:
case ts.SyntaxKind.DoStatement:
case ts.SyntaxKind.ForStatement:
2017-12-10 21:51:33 +01:00
case ts.SyntaxKind.PrefixUnaryExpression:
2017-08-14 05:01:11 +02:00
return true;
2017-05-28 00:38:50 +02:00
default:
return false;
}
}
2018-09-20 02:56:13 +02:00
var templateObject_1;