2017-05-28 00:38:50 +02:00
"use strict" ;
/ * *
* @ license
* Copyright 2017 Palantir Technologies , Inc .
*
* Licensed under the Apache License , Version 2.0 ( the "License" ) ;
* you may not use this file except in compliance with the License .
* You may obtain a copy of the License at
*
* http : //www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing , software
* distributed under the License is distributed on an "AS IS" BASIS ,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND , either express or implied .
* See the License for the specific language governing permissions and
* limitations under the License .
* /
Object . defineProperty ( exports , "__esModule" , { value : true } ) ;
var tslib _1 = require ( "tslib" ) ;
var tsutils _1 = require ( "tsutils" ) ;
var ts = require ( "typescript" ) ;
var Lint = require ( "../index" ) ;
2017-10-14 18:40:54 +02:00
var Rule = /** @class */ ( function ( _super ) {
2017-05-28 00:38:50 +02:00
tslib _1 . _ _extends ( Rule , _super ) ;
function Rule ( ) {
return _super !== null && _super . apply ( this , arguments ) || this ;
}
Rule . prototype . apply = function ( sourceFile ) {
return this . applyWithFunction ( sourceFile , walk ) ;
} ;
2017-08-14 05:01:11 +02:00
/* tslint:disable:object-literal-sort-keys */
Rule . metadata = {
ruleName : "no-misused-new" ,
description : "Warns on apparent attempts to define constructors for interfaces or `new` for classes." ,
optionsDescription : "Not configurable." ,
options : null ,
optionExamples : [ true ] ,
2018-09-20 02:56:13 +02:00
rationale : Lint . Utils . dedent ( templateObject _1 || ( templateObject _1 = tslib _1 . _ _makeTemplateObject ( [ "\n Interfaces in TypeScript aren't meant to describe constructors on their implementations.\n The `new` descriptor is primarily for describing JavaScript libraries.\n If you're trying to describe a function known to be a class, it's typically better to `declare class`.\n " ] , [ "\n Interfaces in TypeScript aren't meant to describe constructors on their implementations.\n The \\`new\\` descriptor is primarily for describing JavaScript libraries.\n If you're trying to describe a function known to be a class, it's typically better to \\`declare class\\`.\n " ] ) ) ) ,
2017-08-14 05:01:11 +02:00
type : "functionality" ,
typescriptOnly : true ,
} ;
/* tslint:enable:object-literal-sort-keys */
Rule . FAILURE _STRING _INTERFACE = "Interfaces cannot be constructed, only classes. Did you mean `declare class`?" ;
Rule . FAILURE _STRING _CLASS = '`new` in a class is a method named "new". Did you mean `constructor`?' ;
2017-05-28 00:38:50 +02:00
return Rule ;
} ( Lint . Rules . AbstractRule ) ) ;
exports . Rule = Rule ;
function walk ( ctx ) {
return ts . forEachChild ( ctx . sourceFile , function cb ( node ) {
if ( tsutils _1 . isMethodSignature ( node ) ) {
if ( tsutils _1 . getPropertyName ( node . name ) === "constructor" ) {
ctx . addFailureAtNode ( node , Rule . FAILURE _STRING _INTERFACE ) ;
}
}
else if ( tsutils _1 . isMethodDeclaration ( node ) ) {
if ( node . body === undefined &&
tsutils _1 . getPropertyName ( node . name ) === "new" &&
returnTypeMatchesParent ( node . parent , node ) ) {
ctx . addFailureAtNode ( node , Rule . FAILURE _STRING _CLASS ) ;
}
}
else if ( tsutils _1 . isConstructSignatureDeclaration ( node ) ) {
if ( returnTypeMatchesParent ( node . parent , node ) ) {
ctx . addFailureAtNode ( node , Rule . FAILURE _STRING _INTERFACE ) ;
}
}
return ts . forEachChild ( node , cb ) ;
} ) ;
}
function returnTypeMatchesParent ( parent , decl ) {
if ( parent . name === undefined || decl . type === undefined || ! tsutils _1 . isTypeReferenceNode ( decl . type ) ) {
return false ;
}
return decl . type . typeName . kind === ts . SyntaxKind . Identifier && decl . type . typeName . text === parent . name . text ;
}
2018-09-20 02:56:13 +02:00
var templateObject _1 ;