2017-05-28 00:38:50 +02:00
"use strict" ;
/ * *
* @ license
* Copyright 2013 Palantir Technologies , Inc .
*
* Licensed under the Apache License , Version 2.0 ( the "License" ) ;
* you may not use this file except in compliance with the License .
* You may obtain a copy of the License at
*
* http : //www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing , software
* distributed under the License is distributed on an "AS IS" BASIS ,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND , either express or implied .
* See the License for the specific language governing permissions and
* limitations under the License .
* /
Object . defineProperty ( exports , "__esModule" , { value : true } ) ;
var tslib _1 = require ( "tslib" ) ;
var tsutils _1 = require ( "tsutils" ) ;
var ts = require ( "typescript" ) ;
var Lint = require ( "../index" ) ;
2017-08-14 05:01:11 +02:00
var ALLOW _EMPTY _CATCH = "allow-empty-catch" ;
2017-10-14 18:40:54 +02:00
var Rule = /** @class */ ( function ( _super ) {
2017-05-28 00:38:50 +02:00
tslib _1 . _ _extends ( Rule , _super ) ;
function Rule ( ) {
return _super !== null && _super . apply ( this , arguments ) || this ;
}
Rule . prototype . apply = function ( sourceFile ) {
2017-08-14 05:01:11 +02:00
return this . applyWithFunction ( sourceFile , walk , {
allowEmptyCatch : this . ruleArguments . indexOf ( ALLOW _EMPTY _CATCH ) !== - 1 ,
} ) ;
2017-05-28 00:38:50 +02:00
} ;
2017-08-14 05:01:11 +02:00
/* tslint:disable:object-literal-sort-keys */
Rule . metadata = {
ruleName : "no-empty" ,
description : "Disallows empty blocks." ,
descriptionDetails : "Blocks with a comment inside are not considered empty." ,
rationale : "Empty blocks are often indicators of missing code." ,
optionsDescription : ( _a = [ "\n If `" , "` is specified, then catch blocks are allowed to be empty." ] , _a . raw = [ "\n If \\`" , "\\` is specified, then catch blocks are allowed to be empty." ] , Lint . Utils . dedent ( _a , ALLOW _EMPTY _CATCH ) ) ,
options : {
type : "string" ,
enum : [ ALLOW _EMPTY _CATCH ] ,
} ,
optionExamples : [ true , [ true , ALLOW _EMPTY _CATCH ] ] ,
type : "functionality" ,
typescriptOnly : false ,
} ;
/* tslint:enable:object-literal-sort-keys */
Rule . FAILURE _STRING = "block is empty" ;
2017-05-28 00:38:50 +02:00
return Rule ;
} ( Lint . Rules . AbstractRule ) ) ;
exports . Rule = Rule ;
function walk ( ctx ) {
return ts . forEachChild ( ctx . sourceFile , function cb ( node ) {
if ( node . kind === ts . SyntaxKind . Block &&
node . statements . length === 0 &&
2017-08-14 05:01:11 +02:00
! isExcluded ( node . parent , ctx . options ) ) {
2017-05-28 00:38:50 +02:00
var start = node . getStart ( ctx . sourceFile ) ;
// Block always starts with open brace. Adding 1 to its start gives us the end of the brace,
// which can be used to conveniently check for comments between braces
if ( Lint . hasCommentAfterPosition ( ctx . sourceFile . text , start + 1 ) ) {
return ;
}
return ctx . addFailure ( start , node . end , Rule . FAILURE _STRING ) ;
}
return ts . forEachChild ( node , cb ) ;
} ) ;
}
2017-08-14 05:01:11 +02:00
function isExcluded ( node , options ) {
if ( options . allowEmptyCatch && node . kind === ts . SyntaxKind . CatchClause ) {
return true ;
}
2017-05-28 00:38:50 +02:00
return tsutils _1 . isConstructorDeclaration ( node ) &&
(
/ * I f c o n s t r u c t o r i s p r i v a t e o r p r o t e c t e d , t h e b l o c k i s a l l o w e d t o b e e m p t y .
The constructor is there on purpose to disallow instantiation from outside the class * /
/ * T h e p u b l i c m o d i f i e r d o e s n o t s e r v e a p u r p o s e h e r e . I t c a n o n l y b e u s e d t o a l l o w i n s t a n t i a t i o n o f a b a s e c l a s s w h e r e
the super constructor is protected . But then the block would not be empty , because of the call to super ( ) * /
tsutils _1 . hasModifier ( node . modifiers , ts . SyntaxKind . PrivateKeyword , ts . SyntaxKind . ProtectedKeyword ) ||
node . parameters . some ( tsutils _1 . isParameterProperty ) ) ;
}
2017-08-14 05:01:11 +02:00
var _a ;