From 7fff4499fd915bcea3fa93b1aa8b35f4fe7a6027 Mon Sep 17 00:00:00 2001 From: Florian Dold Date: Sun, 28 May 2017 00:38:50 +0200 Subject: add linting (and some initial fixes) --- .../lib/rules/strictBooleanExpressionsRule.js | 335 +++++++++++++++++++++ 1 file changed, 335 insertions(+) create mode 100644 node_modules/tslint/lib/rules/strictBooleanExpressionsRule.js (limited to 'node_modules/tslint/lib/rules/strictBooleanExpressionsRule.js') diff --git a/node_modules/tslint/lib/rules/strictBooleanExpressionsRule.js b/node_modules/tslint/lib/rules/strictBooleanExpressionsRule.js new file mode 100644 index 000000000..a202e2c49 --- /dev/null +++ b/node_modules/tslint/lib/rules/strictBooleanExpressionsRule.js @@ -0,0 +1,335 @@ +"use strict"; +/** + * @license + * Copyright 2016 Palantir Technologies, Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +Object.defineProperty(exports, "__esModule", { value: true }); +var tslib_1 = require("tslib"); +var ts = require("typescript"); +var Lint = require("../index"); +var OPTION_ALLOW_NULL_UNION = "allow-null-union"; +var OPTION_ALLOW_UNDEFINED_UNION = "allow-undefined-union"; +var OPTION_ALLOW_STRING = "allow-string"; +var OPTION_ALLOW_NUMBER = "allow-number"; +var OPTION_ALLOW_MIX = "allow-mix"; +// tslint:disable object-literal-sort-keys switch-default +var Rule = (function (_super) { + tslib_1.__extends(Rule, _super); + function Rule() { + return _super !== null && _super.apply(this, arguments) || this; + } + Rule.prototype.applyWithProgram = function (sourceFile, program) { + var options = parseOptions(this.ruleArguments, program.getCompilerOptions().strictNullChecks === true); + return this.applyWithFunction(sourceFile, function (ctx) { return walk(ctx, program.getTypeChecker()); }, options); + }; + return Rule; +}(Lint.Rules.TypedRule)); +Rule.metadata = { + ruleName: "strict-boolean-expressions", + description: (_a = ["\n Restricts the types allowed in boolean expressions. By default only booleans are allowed.\n\n The following nodes are checked:\n\n * Arguments to the `!`, `&&`, and `||` operators\n * The condition in a conditional expression (`cond ? x : y`)\n * Conditions for `if`, `for`, `while`, and `do-while` statements."], _a.raw = ["\n Restricts the types allowed in boolean expressions. By default only booleans are allowed.\n\n The following nodes are checked:\n\n * Arguments to the \\`!\\`, \\`&&\\`, and \\`||\\` operators\n * The condition in a conditional expression (\\`cond ? x : y\\`)\n * Conditions for \\`if\\`, \\`for\\`, \\`while\\`, and \\`do-while\\` statements."], Lint.Utils.dedent(_a)), + optionsDescription: (_b = ["\n These options may be provided:\n\n * `", "` allows union types containing `null`.\n - It does *not* allow `null` itself.\n - Without the '--strictNullChecks' compiler option, this will allow anything other than a string, number, or enum.\n * `", "` allows union types containing `undefined`.\n - It does *not* allow `undefined` itself.\n - Without the '--strictNullChecks' compiler option, this will allow anything other than a string, number, or enum.\n * `", "` allows strings.\n - It does *not* allow unions containing `string`.\n - It does *not* allow string literal types.\n * `", "` allows numbers.\n - It does *not* allow unions containing `number`.\n - It does *not* allow enums or number literal types.\n * `", "` allow multiple of the above to appear together.\n - For example, `string | number` or `RegExp | null | undefined` would normally not be allowed.\n - A type like `\"foo\" | \"bar\" | undefined` is always allowed, because it has only one way to be false."], _b.raw = ["\n These options may be provided:\n\n * \\`", "\\` allows union types containing \\`null\\`.\n - It does *not* allow \\`null\\` itself.\n - Without the '--strictNullChecks' compiler option, this will allow anything other than a string, number, or enum.\n * \\`", "\\` allows union types containing \\`undefined\\`.\n - It does *not* allow \\`undefined\\` itself.\n - Without the '--strictNullChecks' compiler option, this will allow anything other than a string, number, or enum.\n * \\`", "\\` allows strings.\n - It does *not* allow unions containing \\`string\\`.\n - It does *not* allow string literal types.\n * \\`", "\\` allows numbers.\n - It does *not* allow unions containing \\`number\\`.\n - It does *not* allow enums or number literal types.\n * \\`", "\\` allow multiple of the above to appear together.\n - For example, \\`string | number\\` or \\`RegExp | null | undefined\\` would normally not be allowed.\n - A type like \\`\"foo\" | \"bar\" | undefined\\` is always allowed, because it has only one way to be false."], Lint.Utils.dedent(_b, OPTION_ALLOW_NULL_UNION, OPTION_ALLOW_UNDEFINED_UNION, OPTION_ALLOW_STRING, OPTION_ALLOW_NUMBER, OPTION_ALLOW_MIX)), + options: { + type: "array", + items: { + type: "string", + enum: [OPTION_ALLOW_NULL_UNION, OPTION_ALLOW_UNDEFINED_UNION, OPTION_ALLOW_STRING, OPTION_ALLOW_NUMBER], + }, + minLength: 0, + maxLength: 5, + }, + optionExamples: [ + true, + [true, OPTION_ALLOW_NULL_UNION, OPTION_ALLOW_UNDEFINED_UNION, OPTION_ALLOW_STRING, OPTION_ALLOW_NUMBER], + ], + type: "functionality", + typescriptOnly: true, + requiresTypeInfo: true, +}; +exports.Rule = Rule; +function parseOptions(ruleArguments, strictNullChecks) { + return { + strictNullChecks: strictNullChecks, + allowNullUnion: has(OPTION_ALLOW_NULL_UNION), + allowUndefinedUnion: has(OPTION_ALLOW_UNDEFINED_UNION), + allowString: has(OPTION_ALLOW_STRING), + allowNumber: has(OPTION_ALLOW_NUMBER), + allowMix: has(OPTION_ALLOW_MIX), + }; + function has(name) { + return ruleArguments.indexOf(name) !== -1; + } +} +function walk(ctx, checker) { + var sourceFile = ctx.sourceFile, options = ctx.options; + ts.forEachChild(sourceFile, function cb(node) { + switch (node.kind) { + case ts.SyntaxKind.BinaryExpression: { + var b_1 = node; + if (binaryBooleanExpressionKind(b_1) !== undefined) { + var left = b_1.left, right = b_1.right; + var checkHalf = function (expr) { + // If it's another boolean binary expression, we'll check it when recursing. + if (!isBooleanBinaryExpression(expr)) { + checkExpression(expr, b_1); + } + }; + checkHalf(left); + checkHalf(right); + } + break; + } + case ts.SyntaxKind.PrefixUnaryExpression: { + var _a = node, operator = _a.operator, operand = _a.operand; + if (operator === ts.SyntaxKind.ExclamationToken) { + checkExpression(operand, node); + } + break; + } + case ts.SyntaxKind.IfStatement: + case ts.SyntaxKind.WhileStatement: + case ts.SyntaxKind.DoStatement: { + var c = node; + // If it's a boolean binary expression, we'll check it when recursing. + if (!isBooleanBinaryExpression(c.expression)) { + checkExpression(c.expression, c); + } + break; + } + case ts.SyntaxKind.ConditionalExpression: + checkExpression(node.condition, node); + break; + case ts.SyntaxKind.ForStatement: { + var condition = node.condition; + if (condition !== undefined) { + checkExpression(condition, node); + } + break; + } + } + return ts.forEachChild(node, cb); + }); + function checkExpression(node, location) { + var type = checker.getTypeAtLocation(node); + var failure = getTypeFailure(type, options); + if (failure !== undefined) { + if (failure === 0 /* AlwaysTruthy */ && + !options.strictNullChecks && + (options.allowNullUnion || options.allowUndefinedUnion)) { + // OK; It might be null/undefined. + return; + } + ctx.addFailureAtNode(node, showFailure(location, failure, isUnionType(type), options)); + } + } +} +function getTypeFailure(type, options) { + if (isUnionType(type)) { + return handleUnion(type, options); + } + var kind = getKind(type); + var failure = failureForKind(kind, /*isInUnion*/ false, options); + if (failure !== undefined) { + return failure; + } + switch (triState(kind)) { + case true: + return 0 /* AlwaysTruthy */; + case false: + return 1 /* AlwaysFalsy */; + case undefined: + return undefined; + } +} +function handleUnion(type, options) { + // Tracks whether it's possibly truthy. + var anyTruthy = false; + // Counts falsy kinds to see if there's a mix. Also tracks whether it's possibly falsy. + var seenFalsy = 0; + for (var _i = 0, _a = type.types; _i < _a.length; _i++) { + var ty = _a[_i]; + var kind = getKind(ty); + var failure = failureForKind(kind, /*isInUnion*/ true, options); + if (failure !== undefined) { + return failure; + } + switch (triState(kind)) { + case true: + anyTruthy = true; + break; + case false: + seenFalsy++; + break; + default: + anyTruthy = true; + seenFalsy++; + } + } + return seenFalsy === 0 ? 0 /* AlwaysTruthy */ + : !anyTruthy ? 1 /* AlwaysFalsy */ + : !options.allowMix && seenFalsy > 1 ? 7 /* Mixes */ : undefined; +} +/** Fails if a kind of falsiness is not allowed. */ +function failureForKind(kind, isInUnion, options) { + switch (kind) { + case 0 /* String */: + case 1 /* FalseStringLiteral */: + return options.allowString ? undefined : 2 /* String */; + case 2 /* Number */: + case 3 /* FalseNumberLiteral */: + return options.allowNumber ? undefined : 3 /* Number */; + case 8 /* Enum */: + return 6 /* Enum */; + case 6 /* Null */: + return isInUnion && !options.allowNullUnion ? 4 /* Null */ : undefined; + case 7 /* Undefined */: + return isInUnion && !options.allowUndefinedUnion ? 5 /* Undefined */ : undefined; + default: + return undefined; + } +} +/** Divides a type into always true, always false, or unknown. */ +function triState(kind) { + switch (kind) { + case 0 /* String */: + case 2 /* Number */: + case 4 /* Boolean */: + case 8 /* Enum */: + return undefined; + case 6 /* Null */: + case 7 /* Undefined */: + case 3 /* FalseNumberLiteral */: + case 1 /* FalseStringLiteral */: + case 5 /* FalseBooleanLiteral */: + return false; + case 9 /* AlwaysTruthy */: + return true; + } +} +function getKind(type) { + return is(ts.TypeFlags.String) ? 0 /* String */ + : is(ts.TypeFlags.Number) ? 2 /* Number */ + : is(ts.TypeFlags.Boolean) ? 4 /* Boolean */ + : is(ts.TypeFlags.Null) ? 6 /* Null */ + : is(ts.TypeFlags.Undefined | ts.TypeFlags.Void) ? 7 /* Undefined */ + : is(ts.TypeFlags.EnumLike) ? 8 /* Enum */ + : is(ts.TypeFlags.NumberLiteral) ? + (numberLiteralIsZero(type) ? 3 /* FalseNumberLiteral */ : 9 /* AlwaysTruthy */) + : is(ts.TypeFlags.StringLiteral) ? + (stringLiteralIsEmpty(type) ? 1 /* FalseStringLiteral */ : 9 /* AlwaysTruthy */) + : is(ts.TypeFlags.BooleanLiteral) ? + (type.intrinsicName === "true" ? 9 /* AlwaysTruthy */ : 5 /* FalseBooleanLiteral */) + : 9 /* AlwaysTruthy */; + function is(flags) { + return Lint.isTypeFlagSet(type, flags); + } +} +function numberLiteralIsZero(type) { + // Uses 'value' in TypeScript>=2.4. + return type.value !== undefined ? type.value === 0 : type.text === "0"; +} +function stringLiteralIsEmpty(type) { + return (type.value !== undefined ? type.value : type.text) === ""; +} +/** Matches `&&` and `||` operators. */ +function isBooleanBinaryExpression(node) { + return node.kind === ts.SyntaxKind.BinaryExpression && binaryBooleanExpressionKind(node) !== undefined; +} +function binaryBooleanExpressionKind(node) { + switch (node.operatorToken.kind) { + case ts.SyntaxKind.AmpersandAmpersandToken: + return "&&"; + case ts.SyntaxKind.BarBarToken: + return "||"; + default: + return undefined; + } +} +function stringOr(parts) { + switch (parts.length) { + case 1: + return parts[0]; + case 2: + return parts[0] + " or " + parts[1]; + default: + var res = ""; + for (var i = 0; i < parts.length - 1; i++) { + res += parts[i] + ", "; + } + return res + "or " + parts[parts.length - 1]; + } +} +function isUnionType(type) { + return Lint.isTypeFlagSet(type, ts.TypeFlags.Union) && !Lint.isTypeFlagSet(type, ts.TypeFlags.Enum); +} +function showLocation(n) { + switch (n.kind) { + case ts.SyntaxKind.PrefixUnaryExpression: + return "operand for the '!' operator"; + case ts.SyntaxKind.ConditionalExpression: + return "condition"; + case ts.SyntaxKind.ForStatement: + return "'for' condition"; + case ts.SyntaxKind.IfStatement: + return "'if' condition"; + case ts.SyntaxKind.WhileStatement: + return "'while' condition"; + case ts.SyntaxKind.DoStatement: + return "'do-while' condition"; + case ts.SyntaxKind.BinaryExpression: + return "operand for the '" + binaryBooleanExpressionKind(n) + "' operator"; + } +} +function showFailure(location, ty, isUnionType, options) { + var expectedTypes = showExpectedTypes(options); + var expected = expectedTypes.length === 1 + ? "Only " + expectedTypes[0] + "s are allowed" + : "Allowed types are " + stringOr(expectedTypes); + var tyFail = showTypeFailure(ty, isUnionType, options.strictNullChecks); + return "This type is not allowed in the " + showLocation(location) + " because it " + tyFail + ". " + expected + "."; +} +function showExpectedTypes(options) { + var parts = ["boolean"]; + if (options.allowNullUnion) { + parts.push("null-union"); + } + if (options.allowUndefinedUnion) { + parts.push("undefined-union"); + } + if (options.allowString) { + parts.push("string"); + } + if (options.allowNumber) { + parts.push("number"); + } + return parts; +} +function showTypeFailure(ty, isUnionType, strictNullChecks) { + var is = isUnionType ? "could be" : "is"; + switch (ty) { + case 0 /* AlwaysTruthy */: + return strictNullChecks + ? "is always truthy" + : "is always truthy. It may be null/undefined, but neither " + + ("'" + OPTION_ALLOW_NULL_UNION + "' nor '" + OPTION_ALLOW_UNDEFINED_UNION + "' is set"); + case 1 /* AlwaysFalsy */: return "is always falsy"; + case 2 /* String */: return is + " a string"; + case 3 /* Number */: return is + " a number"; + case 4 /* Null */: return is + " null"; + case 5 /* Undefined */: return is + " undefined"; + case 6 /* Enum */: return is + " an enum"; + case 7 /* Mixes */: return "unions more than one truthy/falsy type"; + } +} +var _a, _b; -- cgit v1.2.3