From 7fff4499fd915bcea3fa93b1aa8b35f4fe7a6027 Mon Sep 17 00:00:00 2001 From: Florian Dold Date: Sun, 28 May 2017 00:38:50 +0200 Subject: add linting (and some initial fixes) --- .../tslint/lib/rules/restrictPlusOperandsRule.js | 79 ++++++++++++++++++++++ 1 file changed, 79 insertions(+) create mode 100644 node_modules/tslint/lib/rules/restrictPlusOperandsRule.js (limited to 'node_modules/tslint/lib/rules/restrictPlusOperandsRule.js') diff --git a/node_modules/tslint/lib/rules/restrictPlusOperandsRule.js b/node_modules/tslint/lib/rules/restrictPlusOperandsRule.js new file mode 100644 index 000000000..229d170be --- /dev/null +++ b/node_modules/tslint/lib/rules/restrictPlusOperandsRule.js @@ -0,0 +1,79 @@ +"use strict"; +/** + * @license + * Copyright 2016 Palantir Technologies, Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +Object.defineProperty(exports, "__esModule", { value: true }); +var tslib_1 = require("tslib"); +var tsutils_1 = require("tsutils"); +var ts = require("typescript"); +var Lint = require("../index"); +var Rule = (function (_super) { + tslib_1.__extends(Rule, _super); + function Rule() { + return _super !== null && _super.apply(this, arguments) || this; + } + Rule.prototype.applyWithProgram = function (sourceFile, program) { + return this.applyWithFunction(sourceFile, function (ctx) { return walk(ctx, program); }); + }; + return Rule; +}(Lint.Rules.TypedRule)); +/* tslint:disable:object-literal-sort-keys */ +Rule.metadata = { + ruleName: "restrict-plus-operands", + description: "When adding two variables, operands must both be of type number or of type string.", + optionsDescription: "Not configurable.", + options: null, + optionExamples: [true], + type: "functionality", + typescriptOnly: false, + requiresTypeInfo: true, +}; +/* tslint:enable:object-literal-sort-keys */ +Rule.INVALID_TYPES_ERROR = "Operands of '+' operation must either be both strings or both numbers"; +exports.Rule = Rule; +function walk(ctx, program) { + return ts.forEachChild(ctx.sourceFile, function cb(node) { + if (tsutils_1.isBinaryExpression(node) && node.operatorToken.kind === ts.SyntaxKind.PlusToken) { + var tc = program.getTypeChecker(); + var leftType = getBaseTypeOfLiteralType(tc.getTypeAtLocation(node.left)); + var rightType = getBaseTypeOfLiteralType(tc.getTypeAtLocation(node.right)); + if (leftType === "invalid" || rightType === "invalid" || leftType !== rightType) { + return ctx.addFailureAtNode(node, Rule.INVALID_TYPES_ERROR); + } + } + return ts.forEachChild(node, cb); + }); +} +function getBaseTypeOfLiteralType(type) { + if (Lint.isTypeFlagSet(type, ts.TypeFlags.StringLiteral) || Lint.isTypeFlagSet(type, ts.TypeFlags.String)) { + return "string"; + } + else if (Lint.isTypeFlagSet(type, ts.TypeFlags.NumberLiteral) || Lint.isTypeFlagSet(type, ts.TypeFlags.Number)) { + return "number"; + } + else if (tsutils_1.isUnionType(type) && !Lint.isTypeFlagSet(type, ts.TypeFlags.Enum)) { + var types = type.types.map(getBaseTypeOfLiteralType); + return allSame(types) ? types[0] : "invalid"; + } + else if (Lint.isTypeFlagSet(type, ts.TypeFlags.EnumLiteral)) { + // Compatibility for TypeScript pre-2.4, which used EnumLiteralType instead of LiteralType + getBaseTypeOfLiteralType(type.baseType); + } + return "invalid"; +} +function allSame(array) { + return array.every(function (value) { return value === array[0]; }); +} -- cgit v1.2.3