From 7fff4499fd915bcea3fa93b1aa8b35f4fe7a6027 Mon Sep 17 00:00:00 2001 From: Florian Dold Date: Sun, 28 May 2017 00:38:50 +0200 Subject: add linting (and some initial fixes) --- node_modules/tslint/lib/rules/noNamespaceRule.js | 75 ++++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 node_modules/tslint/lib/rules/noNamespaceRule.js (limited to 'node_modules/tslint/lib/rules/noNamespaceRule.js') diff --git a/node_modules/tslint/lib/rules/noNamespaceRule.js b/node_modules/tslint/lib/rules/noNamespaceRule.js new file mode 100644 index 000000000..a930e3034 --- /dev/null +++ b/node_modules/tslint/lib/rules/noNamespaceRule.js @@ -0,0 +1,75 @@ +"use strict"; +/** + * @license + * Copyright 2016 Palantir Technologies, Inc. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +Object.defineProperty(exports, "__esModule", { value: true }); +var tslib_1 = require("tslib"); +var tsutils_1 = require("tsutils"); +var ts = require("typescript"); +var Lint = require("../index"); +var OPTION_ALLOW_DECLARATIONS = "allow-declarations"; +var Rule = (function (_super) { + tslib_1.__extends(Rule, _super); + function Rule() { + return _super !== null && _super.apply(this, arguments) || this; + } + Rule.prototype.apply = function (sourceFile) { + return this.applyWithFunction(sourceFile, walk, { + allowDeclarations: this.ruleArguments.indexOf(OPTION_ALLOW_DECLARATIONS) !== -1, + }); + }; + return Rule; +}(Lint.Rules.AbstractRule)); +/* tslint:disable:object-literal-sort-keys */ +Rule.metadata = { + ruleName: "no-namespace", + description: "Disallows use of internal \`module\`s and \`namespace\`s.", + descriptionDetails: "This rule still allows the use of `declare module ... {}`", + rationale: (_a = ["\n ES6-style external modules are the standard way to modularize code.\n Using `module {}` and `namespace {}` are outdated ways to organize TypeScript code."], _a.raw = ["\n ES6-style external modules are the standard way to modularize code.\n Using \\`module {}\\` and \\`namespace {}\\` are outdated ways to organize TypeScript code."], Lint.Utils.dedent(_a)), + optionsDescription: (_b = ["\n One argument may be optionally provided:\n\n * `", "` allows `declare namespace ... {}` to describe external APIs."], _b.raw = ["\n One argument may be optionally provided:\n\n * \\`", "\\` allows \\`declare namespace ... {}\\` to describe external APIs."], Lint.Utils.dedent(_b, OPTION_ALLOW_DECLARATIONS)), + options: { + type: "array", + items: { + type: "string", + enum: [OPTION_ALLOW_DECLARATIONS], + }, + minLength: 0, + maxLength: 1, + }, + optionExamples: [true, [true, OPTION_ALLOW_DECLARATIONS]], + type: "typescript", + typescriptOnly: true, +}; +/* tslint:enable:object-literal-sort-keys */ +Rule.FAILURE_STRING = "'namespace' and 'module' are disallowed"; +exports.Rule = Rule; +function walk(ctx) { + // Ignore all .d.ts files by returning and not walking their ASTs. + // .d.ts declarations do not have the Ambient flag set, but are still declarations. + if (ctx.sourceFile.isDeclarationFile && ctx.options.allowDeclarations) { + return; + } + for (var _i = 0, _a = ctx.sourceFile.statements; _i < _a.length; _i++) { + var node = _a[_i]; + if (node.kind === ts.SyntaxKind.ModuleDeclaration) { + if (node.name.kind !== ts.SyntaxKind.StringLiteral && + (!ctx.options.allowDeclarations || !tsutils_1.hasModifier(node.modifiers, ts.SyntaxKind.DeclareKeyword))) { + ctx.addFailureAtNode(node, Rule.FAILURE_STRING); + } + } + } +} +var _a, _b; -- cgit v1.2.3