Commit Graph

588 Commits

Author SHA1 Message Date
Lucien Heuzeveldt
7d2a1a596a
split .conf files into rsa and cs 2022-02-04 19:24:30 +01:00
Gian Demarmels
8674f32aec
denomination CIPHER field per denom 2022-02-04 15:39:57 +01:00
Christian Grothoff
e7aeec04f4
The current recoup API is broken. I guess this is another example where "trivial" API changes turn out to have (multiple!) unexpected consequences.
The current "/recoup" API does not have clear idempotency semantics, as we've discussed on the phone.  This is already bad by itself, as it makes it hard to write down what the API does other than "whatever the implementation does".

However, it actually breaks correctness in this (admittedly kinda contrived, but not impossible) case:

Say that we have a coin A obtained via withdrawal and a coin B obtained via refreshing coin A. Now the denominations of A gets revoked..

The wallet does a recoup of A for EUR:1.

Now the denomination of B also gets revoked.  The wallet recoups B (incidentally also for EUR:1) and now A can be recouped again for EUR:1.  But now the exchange is in a state where it will refuse a legitimate recoup request for A because the detection for an idempotent request kicks in.

This is IMHO bad API design, and the exchange should simply always recoup the maximum amount.

Furthermore, we usually follow the principle of "API calls that take up DB space are paid".  With the current recoup API, I can do many tiny recoup requests which the exchange then has to store, right?

I guess it would not be a big change to remove the "amount" value from the recoup/recoup-refresh request bodies, right?

- Florian
2022-01-11 12:47:35 +01:00
Christian Grothoff
84c9adf5a6
v12: also do not sign over merchant_pub in REFUND signature, centralize logic 2021-12-25 14:58:04 +01:00
Christian Grothoff
87376e02eb
protocol v12 changes (/recoup split, signature changes) plus database sharding plus O(n^2)=>O(n) worst-case complexity reduction on coin balance checks 2021-12-25 13:56:40 +01:00
Christian Grothoff
2c14d33870
deduplicate melt signing logic, remove coin_pub from data being signed over 2021-12-25 13:56:40 +01:00
Christian Grothoff
1acc851deb
-fix recoup ugliness 2021-12-16 20:18:44 +01:00
Christian Grothoff
1a1fafbd43
introducing GNUNET_TIME_Timestamp, recoup now with amounts 2021-12-14 16:04:40 +01:00
bed2a422a5
-basedb 2021-12-01 15:04:57 +01:00
ebc5f4f986
fix auditor test case, re-generate basedbs 2021-12-01 14:21:35 +01:00
Christian Grothoff
d3615c708f
-fix typos 2021-11-29 17:48:39 +01:00
Christian Grothoff
935c2d4e62
-improve logging 2021-11-20 09:42:25 +01:00
Christian Grothoff
bdaaa0f6cb
-fix misc. compiler warnings 2021-11-19 10:57:27 +01:00
Christian Grothoff
91628260f6
fix warning 2021-11-16 16:56:30 +01:00
Christian Grothoff
81f9b2c93e
-misc fixes 2021-11-06 19:57:34 +01:00
Christian Grothoff
9d6e104066
include h_extensions in deposit confirmation 2021-11-06 19:43:47 +01:00
Christian Grothoff
8175fdfa0f
introduce TALER_wallet_deposit_verify 2021-11-06 16:52:14 +01:00
Christian Grothoff
ba627bf84c
-fixes 2021-11-05 22:22:47 +01:00
Christian Grothoff
32da809fd6
abstract denomination keys a bit more 2021-11-05 14:00:10 +01:00
Christian Grothoff
d68dc69b4c
-disable tests 2021-10-31 18:20:27 +01:00
Christian Grothoff
43ee9da01d
misc fixes 2021-10-31 12:49:51 +01:00
Christian Grothoff
2faf102a05
-more dB work 2021-10-30 21:26:40 +02:00
Christian Grothoff
bc57abc3da
-more dB work 2021-10-30 20:49:23 +02:00
Christian Grothoff
963a06c0aa
fix more FTBFS issues 2021-10-30 19:28:11 +02:00
Christian Grothoff
7ac57acb18
fix auditor FTBFS 2021-10-27 09:23:14 +02:00
Christian Grothoff
ca12adced4
-basic logic for withdraw KYC checks 2021-10-14 21:06:47 +02:00
Christian Grothoff
acbadd5c6e
-modify C API to future-proof it for returning more details as required for KYC implementation 2021-10-13 18:52:59 +02:00
Christian Grothoff
889bd801bc
-vanilla DB has no deposits, hence no lag 2021-09-27 11:36:09 +02:00
Christian Grothoff
26c0dc7841
-fix output formatting 2021-09-27 11:32:54 +02:00
Christian Grothoff
4cff3c1a5c
-fix unbound varibale 2021-09-27 11:14:29 +02:00
Christian Grothoff
f9a69b423b
fix auditor test DB generation logic and re-generate databases 2021-09-05 16:00:42 +02:00
Christian Grothoff
adc6c53b5c
doxygen and spelling fixes 2021-09-04 13:00:20 +02:00
Christian Grothoff
5149af9314
preliminary work on supporting sharding/parallel aggregation (undertested, but tests pass again) 2021-09-03 19:08:02 +02:00
Christian Grothoff
01e06eb715
-remove sessions also from auditor 2021-08-23 08:24:59 +02:00
Christian Grothoff
c559b1c935
complete implementation of long-polling for reserve status; remove support for multi-threaded exchange httpd 2021-08-23 00:00:32 +02:00
Christian Grothoff
f174781b57
support long_poll_ms argument in bank API (#6987) 2021-08-12 13:13:42 +02:00
Christian Grothoff
b58605a79d
introduce TALER_OS_init() to safely handle static linkage 2021-08-08 16:45:32 +02:00
adf854cd4a
load config file from correct location 2021-08-04 21:49:21 +02:00
Christian Grothoff
ba3f70390a
restructure configuration, move bank account credentials from exchange-account-XXX to exchange-accountcredentials-XXX 2021-08-03 21:58:36 +02:00
Christian Grothoff
33a28efef7
-more json_pack fixes 2021-07-31 21:48:36 +02:00
Christian Grothoff
fde9dc80f6
-more json_pack cleaning 2021-07-31 21:40:48 +02:00
Christian Grothoff
af9830453e
REVOCATION_DIR is long obsolete, KEYDIR was renamed to KEY_DIR and is in another section 2021-07-30 17:31:18 +02:00
Christian Grothoff
d821db366a
-fix misc enum confusions and other compiler warnings 2021-07-30 13:32:03 +02:00
Christian Grothoff
0ef7c0a0b7
fix #6960 2021-07-29 23:56:46 +02:00
02aa49cc36
install into usr/share/taler/exchange 2021-07-26 16:16:52 +02:00
Christian Grothoff
42decef957
fix #6939 in exchange 2021-07-24 09:00:35 +02:00
Christian Grothoff
306a08a71c
-rename TALER_amount_get_zero to TALER_amount_set_zero 2021-07-23 13:02:04 +02:00
Christian Grothoff
67559ad626
fix #6919: add new tables to basedbs 2021-07-18 13:31:17 +02:00
Christian Grothoff
d1e5fd8f0e
pass config to dbinit in test 2021-07-18 12:48:56 +02:00
Christian Grothoff
883b1fc70b
-clean taler-auditor shell script, too 2021-06-28 12:16:04 +02:00