Commit Graph

282 Commits

Author SHA1 Message Date
Christian Grothoff
41acdf11b8
make API actually workable, sketch out melt 2022-02-05 00:02:38 +01:00
Christian Grothoff
b30765c7d0
make API actually workable, sketch out melt 2022-02-04 23:58:41 +01:00
Christian Grothoff
cfc6c3fcd0
make API actually workable: 2022-02-04 23:09:19 +01:00
Christian Grothoff
d833966d52
-API work 2022-02-04 22:02:48 +01:00
Christian Grothoff
bd5a25aff2
-fix comment 2022-02-04 21:20:26 +01:00
Christian Grothoff
57dc3cd232
new API 2022-02-04 21:12:54 +01:00
Christian Grothoff
ed136c1f2d
sync 2022-02-04 20:02:16 +01:00
Christian Grothoff
03fd154a69
messing with CS/RSA fixes 2022-02-04 19:30:15 +01:00
Gian Demarmels
be50c084f8
fixed nonce check, renamed WithdrawNonce 2022-02-04 15:37:33 +01:00
Lucien Heuzeveldt
8d85c8b5b6
implement feedback 2022-02-04 15:37:30 +01:00
Lucien Heuzeveldt
82405b0ce5
implement CS key handling and csr endpoint 2022-02-04 15:34:19 +01:00
Lucien Heuzeveldt
fbb6d03f69
fix const due to changes in TALER_planchet_prepare 2022-02-04 15:33:10 +01:00
Lucien Heuzeveldt
3225566c93
implement exchange_api_csr 2022-02-04 15:33:07 +01:00
8684a9bfea
[age_restriction] progress 13/n
- major refactoring of extensions
  - extensions live now in a separate library, libtalerextensions
  - refactored all components using age_restriction accordingly
  - plumbing for plugin support for extensions roughly layed down
2022-01-23 01:36:21 +01:00
0b56de6c99
[age restriction] progress 12/n
- taler-offline-tool now handles extensions
  - command "extensions" added with subcommands "show" and "sign"
  - parses extensions from taler config
  - shows and signs of extensions and their configurations
  - creates signed set of configurations for upload
  - added test for retrieval of extension config

- simplified signature verification for extensions
  - remove per-extension signatures, also from DB schema
  - adjust prepared statements accordingly
  - adjust DB event handler for extensions
  - allow NULL for config for extension in DB schema
  - handler for /management/extensions adjusted to new datastructures

- changed test for TALER_denom_blind/TALER_denom_sign_blinded with and
  without TALER_AgeHash

- minor updates and various fixes
2022-01-21 15:41:02 +01:00
Christian Grothoff
e7aeec04f4
The current recoup API is broken. I guess this is another example where "trivial" API changes turn out to have (multiple!) unexpected consequences.
The current "/recoup" API does not have clear idempotency semantics, as we've discussed on the phone.  This is already bad by itself, as it makes it hard to write down what the API does other than "whatever the implementation does".

However, it actually breaks correctness in this (admittedly kinda contrived, but not impossible) case:

Say that we have a coin A obtained via withdrawal and a coin B obtained via refreshing coin A. Now the denominations of A gets revoked..

The wallet does a recoup of A for EUR:1.

Now the denomination of B also gets revoked.  The wallet recoups B (incidentally also for EUR:1) and now A can be recouped again for EUR:1.  But now the exchange is in a state where it will refuse a legitimate recoup request for A because the detection for an idempotent request kicks in.

This is IMHO bad API design, and the exchange should simply always recoup the maximum amount.

Furthermore, we usually follow the principle of "API calls that take up DB space are paid".  With the current recoup API, I can do many tiny recoup requests which the exchange then has to store, right?

I guess it would not be a big change to remove the "amount" value from the recoup/recoup-refresh request bodies, right?

- Florian
2022-01-11 12:47:35 +01:00
e30989c930
[age restriction] progress 11/n
Parse age restriction information from "/keys"
- parse "age_restriction" extension, extract mask for age groups
- parse denominations from "age_restricted_denoms", too, if available
2022-01-10 00:04:23 +01:00
ef4238874f
[age restriction] progress 9/n
More worke towards support for extensions and age restriction:

- taler-exchange-httpd_management_extensions.c almost completed
  - handling of request implemented
  - stub "set_extensions" for database transaction added

- utility functions added
  - TALER_exchange_offline_extension_agemask_{sign,verify}
  - TALER_agemask_parse_json
2021-12-27 23:24:48 +01:00
Christian Grothoff
87376e02eb
protocol v12 changes (/recoup split, signature changes) plus database sharding plus O(n^2)=>O(n) worst-case complexity reduction on coin balance checks 2021-12-25 13:56:40 +01:00
1b23857f2c
[age restriction] progress 8/n
More work towards support for extensions and age restriction

- updated gana
- added handler for DB-Event
- added TEH_extensions_init() and _done()
- added global for age restriction
- added stub for post handler
- added SQL-table for extension metadata
- added enum type for extensions and other data structures

Also:
- fixed some warnings -Wmaybe-unitialized
2021-12-23 15:15:33 +01:00
Christian Grothoff
1a1fafbd43
introducing GNUNET_TIME_Timestamp, recoup now with amounts 2021-12-14 16:04:40 +01:00
Christian Grothoff
a9b2140b1e
get first KYC test to pass 2021-11-09 15:39:31 +01:00
Christian Grothoff
121bfe3659
implement /kyc-proof client API 2021-11-07 13:05:33 +01:00
Christian Grothoff
3eae999efc
distinguish between blind and non-blind denomination signatures 2021-10-31 17:56:56 +01:00
Christian Grothoff
41bfdb4509
-fix FTBFS issues 2021-10-31 00:21:46 +02:00
Christian Grothoff
2faf102a05
-more dB work 2021-10-30 21:26:40 +02:00
Christian Grothoff
963a06c0aa
fix more FTBFS issues 2021-10-30 19:28:11 +02:00
Christian Grothoff
77142acbe8
fix lib/ FTBFS 2021-10-27 13:42:54 +02:00
Christian Grothoff
b148a5a81a
rename fest 2021-10-27 13:23:14 +02:00
Christian Grothoff
464c1f806c
-more changes towards fixing FTBFS 2021-10-27 09:23:12 +02:00
Christian Grothoff
55632b1fbf
brutally fixing types in src/include/, creating plenty of FTBFS issues 2021-10-27 09:23:11 +02:00
Christian Grothoff
9adb9cfe61
simplify deposit, do not return kyc status, not needed 2021-10-20 18:56:59 +02:00
Christian Grothoff
bde1394ee4
implement /kyc-wallet in libtalerexchange 2021-10-17 20:30:06 +02:00
Christian Grothoff
932d2aaf88
implement returning KYC status from GET /deposits/ endpoint 2021-10-17 13:22:15 +02:00
Christian Grothoff
d1992e5983
new configuration option: wallet balance threshold 2021-10-16 19:24:08 +02:00
Christian Grothoff
acbadd5c6e
-modify C API to future-proof it for returning more details as required for KYC implementation 2021-10-13 18:52:59 +02:00
Christian Grothoff
8951abfc50
-finish implemnetation of /kyc-check client library 2021-10-10 17:18:24 +02:00
Christian Grothoff
df681b0d95
-draft API for new /kyc-check endpoint 2021-10-10 15:37:05 +02:00
Christian Grothoff
c559b1c935
complete implementation of long-polling for reserve status; remove support for multi-threaded exchange httpd 2021-08-23 00:00:32 +02:00
Christian Grothoff
1d54400a02
-more eliminations of json_pack 2021-07-31 20:27:16 +02:00
Christian Grothoff
20c70845c0
return more precise error codes from TALER_EXCHANGE_deposit() if failures are detected client-side (#6817) 2021-04-24 19:54:47 +02:00
Christian Grothoff
a140c114d3
more doxygen fixes 2021-04-23 23:39:07 +02:00
Sebastian
c1a58ef343
added missing currency in ser/deser, see #6744 2021-02-15 17:03:44 -03:00
Christian Grothoff
260e287685
change wire_reference to be uint64_t always; more work on lrbt_callbacks 2021-01-08 23:36:09 +01:00
Christian Grothoff
699916056b
misc doxygen fixes 2020-12-20 17:10:09 +01:00
Christian Grothoff
70b0839644
implement new taler-auditor-offline tool 2020-12-06 00:05:45 +01:00
Christian Grothoff
4b2504a3c3
doxygen fixes 2020-11-30 14:16:42 +01:00
Christian Grothoff
a1af10a832
add API for /management/wire-fees 2020-11-30 14:05:34 +01:00
Christian Grothoff
a3548f0efb
add command to add auditor's denomination signature 2020-11-30 11:51:42 +01:00
Christian Grothoff
6b434c626f
work on DB logic, add auditor_name to /management/auditors API 2020-11-29 16:21:10 +01:00
Christian Grothoff
1e6091d1dd
cmd to add/del wire methods from list of accounts 2020-11-27 00:05:34 +01:00
Christian Grothoff
98f5960411
cmd to del auditor 2020-11-26 22:54:33 +01:00
Christian Grothoff
2c88cff283
add logic to parse and check secmod signatures 2020-11-26 15:00:34 +01:00
Christian Grothoff
19ca32693a
post keys client logic 2020-11-25 21:55:01 +01:00
Christian Grothoff
4d9b672a72
enable auditor disable client logic 2020-11-25 21:29:04 +01:00
Christian Grothoff
fd91a6aded
implement first new client API 2020-11-25 21:19:13 +01:00
Christian Grothoff
87bc48f513
extended exchange APIs for #6175 2020-11-25 20:26:08 +01:00
Jonathan Buchanan
c24a18e1a5
remove TALER_TESTING_cmd_admin_add_incoming_with_instance and TALER_EXCHANGE_refund2 2020-07-23 16:19:02 -04:00
Florian Dold
93923c168d
remove refund_fee from refund confirmation message and signature 2020-07-22 19:29:27 +05:30
Christian Grothoff
b9f1384b52
avoid boolean flags, see #6188 2020-07-16 20:27:52 +02:00
Christian Grothoff
92ac6dd11a
implement new behavior in exchange httpd and libtalerexchange (for #6416) 2020-07-08 21:24:10 +02:00
Christian Grothoff
97dfbec081
add h_denom_pub to deposit signatures 2020-07-08 15:46:51 +02:00
Christian Grothoff
b0311807ff
fix FIXME by exposing deposit permission signing in API instead of doing it inside of the testing logic 2020-07-05 16:50:15 +02:00
Christian Grothoff
dc9f41a794
clarify with/without wire fee issue, sanity checks on currencies 2020-07-05 16:50:15 +02:00
Christian Grothoff
7f10627a31
update 2020-07-05 16:50:12 +02:00
Christian Grothoff
099102dc57
modify TALER_EXCHANGE_deposits_get() API to avoid NULL pointers and need for deep copies 2020-07-05 16:49:23 +02:00
Christian Grothoff
cdbf3a05ae
modify TALER_EXCHANGE_deposits_get() API to combine returned arguments into a struct (simplifies merchant later) 2020-07-05 16:48:26 +02:00
Christian Grothoff
ef97d426b1
update exchange API to return struct instead of lots of individual args for TALER_EXCHANGE_transfers_get() -- simplifies merchant later 2020-07-05 16:46:41 +02:00
Christian Grothoff
4119dbd1aa
update 2020-07-05 16:44:09 +02:00
Christian Grothoff
035c505c71
modify TALER_EXCHANGE_deposits_get() API to combine returned arguments into a struct (simplifies merchant later) 2020-07-05 16:42:37 +02:00
Christian Grothoff
4f82885560
towards changing timestamp in deposit confirmation (tests failing) 2020-07-05 16:35:00 +02:00
Christian Grothoff
727b7b04f3
return fee as well 2020-07-05 16:35:00 +02:00
Christian Grothoff
4844023f69
modify TALER_EXCHANGE_deposits_get() API to avoid NULL pointers and need for deep copies 2020-07-05 16:35:00 +02:00
Christian Grothoff
cde71b7fe7
modify TALER_EXCHANGE_deposits_get() API to combine returned arguments into a struct (simplifies merchant later) 2020-07-05 16:35:00 +02:00
Christian Grothoff
77ab94eb68
update exchange API to return struct instead of lots of individual args for TALER_EXCHANGE_transfers_get() -- simplifies merchant later 2020-07-05 16:35:00 +02:00
Christian Grothoff
5ac448738d
fix status code 2020-07-05 16:34:59 +02:00
Christian Grothoff
78031b2711
more error codes 2020-05-01 18:38:21 +02:00
Christian Grothoff
9e3371ae9b
adapt withdraw2 API to support new tip-pickup design (#6173) 2020-04-12 19:22:45 +02:00
Christian Grothoff
2d83516871
add missing comment 2020-04-10 21:59:31 +02:00
Christian Grothoff
1b89e8380d
return signature from refund API 2020-04-10 16:49:54 +02:00
Christian Grothoff
bf8c5982a2
make exchange API more uniform in how information is returned 2020-04-05 22:05:38 +02:00
Christian Grothoff
299b4b78e0
return more error details for /wire and /keys to clients 2020-04-04 13:27:46 +02:00
Christian Grothoff
ae9f751a7c
do return fees in history 2020-03-28 20:46:57 +01:00
Florian Dold
6a46b13e80
make recoup idempotent and simplify response 2020-03-20 14:01:59 +05:30
Christian Grothoff
86f2d65daf
style, indentation and type fixes for lib/ 2020-03-17 17:47:53 +01:00
Christian Grothoff
f6684c1ae3
actually look at recoup/revocations in libtalerexchange and expose the result to clients; make exchange API follow specification 2020-03-10 14:25:57 +01:00
Christian Grothoff
ffcadbff8c
code cleanup (comments, scoping, naming, indentation) 2020-03-07 00:28:07 +01:00
Christian Grothoff
72764dc5f1
doxygen fixes 2020-02-29 17:13:43 +01:00
Christian Grothoff
0a2b049864
big rename fest related to #6067 API renaming 2020-02-29 16:42:10 +01:00
Christian Grothoff
de9ab28ab9
rename fest, make symbols better match new endpoint names 2020-02-27 23:46:53 +01:00
Florian Dold
fc8bdb9b97
consistently use payto URI instead of URL 2020-01-19 17:03:19 +01:00
Christian Grothoff
db669ee495
payback -> recoup stranglers 2020-01-18 23:49:37 +01:00
Christian Grothoff
c5c04cb51f
fix -Wextra warnings 2020-01-18 17:53:54 +01:00
Christian Grothoff
47deacaa15
doxygen 2020-01-18 17:06:32 +01:00
Florian Dold
33877b2c55
address fixme, fix use-after-free in testing traits 2020-01-17 20:50:18 +01:00
Christian Grothoff
11c5283711
prepare API to enable verification of fees in coin history check 2020-01-17 19:54:16 +01:00
Christian Grothoff
385b3e77df
tighten formatting rules 2019-10-31 12:59:50 +01:00
Christian Grothoff
47e4dc13ed
add api to allow clients to force auditor notification of dc 2019-10-26 20:51:21 +02:00
Florian Dold
eb55997084
re-format code 2019-08-25 16:18:24 +02:00
Christian Grothoff
8f7388042c
fix indent 2019-08-01 00:24:11 +02:00
Christian Grothoff
9e3f4bdd79
getting revocation/payback test with refreshed coins to pass 2019-07-24 11:57:03 +02:00
Christian Grothoff
e8a892c29a
modify /payback API and test usage of that API to pass/return additional information required when dealing with payback of refreshed coins 2019-07-23 21:56:21 +02:00
Christian Grothoff
ad34305942
expose blinding key in refresh-reveal API in preparation for #5777 2019-07-21 12:20:45 +02:00
Christian Grothoff
4785bcb4bb
towards #5777, adding todos/notes 2019-07-15 22:01:06 +02:00
Marcello Stanisci
6e6ce685ea
Provide API to fake now when requesting /keys. 2019-04-03 18:02:16 +02:00
Marcello Stanisci
148b546435
/keys API.
Adding method to override the last_denom value for a key set.
2019-01-17 16:37:16 +01:00
Marcello Stanisci
448a57d81e
Extend tests.
Give a way to force redownload (= no cherry picking) all /keys.
2019-01-16 19:44:44 +01:00
Christian Grothoff
91566ddee2
more code towards fixing #5447 2019-01-13 16:22:16 +01:00
Christian Grothoff
12123a7aed
towards fixing #5447 2019-01-10 16:20:15 +01:00
Marcello Stanisci
81d1b39343
Extend exchange-lib.
Adding simple function that returns the exchange's base URL.
2018-12-06 18:14:09 +01:00
Christian Grothoff
cf1ce47863
more work towards testing deposit confirmations 2018-11-17 16:11:47 +01:00
Christian Grothoff
4d058c4eb7
work towards testing auditor deposit-confirmation API 2018-11-17 15:15:51 +01:00
Christian Grothoff
16b0c65470
keep a most sigs around when serializing 2018-10-13 19:45:50 +02:00
Christian Grothoff
504017bc65
intermediate patch towards implementing #5136 2018-10-13 19:14:11 +02:00
Christian Grothoff
c09c900922
implement deserialization logic for #5136 2018-10-13 08:15:02 +02:00
Christian Grothoff
a56e2e34bc
fix #5434 (no more salt in exchange wire replies) 2018-10-06 15:05:06 +02:00
Christian Grothoff
528faeab81
fix #5315, including more testing 2018-09-15 22:20:07 +02:00
Marcello Stanisci
5019bd6914
Ask to withdraw on a expired reserve. 2018-05-18 16:54:36 +02:00
Christian Grothoff
202827ebda
merging Florian's changes with my wire changes 2018-04-15 12:20:00 +02:00
Florian Dold
1b3bf1a001
disable /keys cherrypicking until #5315 is addressed 2018-04-06 00:58:15 +02:00
Christian Grothoff
cb55c1a3af
Changing configuration structure to enable multiple accounts.
This change enables using multiple wire plugins at the same time.
Also, we now distinguish between the wire plugin (i.e. EBICS or
taler_bank) and the wire method (i.e. SEPA or x-taler-bank) that
the wire plugin is implementing.  The "taler-bank" wire method
was renamed from "test" to "x-taler-bank".

This also changes the format of the /wire response of the exchange,
as we now need to return multiple accounts.  Note that wire fees
are specified per wire method, not per wire account.

taler-exchange-keyup now automatically signs all of the /wire
responses in the location specified by the configuration.

Account identification in wire plugins was changed to use
payto://-URLs instead of method-specific JSON fields.  Signing
and validation of /wire responses was moved from each wire
plugin to a generic validation method in libtalerutil (crypto)
or libtalerjson (for JSON-formatted inputs).
Convenience methods were added to generate JSON for wire accounts
(salting, signing).

Various section and option names were adjusted to streamline the
configuration and make it more consistent overall.  Documentation
was updated as well.
2018-04-02 14:29:44 +02:00
Christian Grothoff
5c3d25eb29
implement #5254 2018-01-18 16:55:16 +01:00
Christian Grothoff
b31d803c16
add timestamp for /reserve/status deposit events 2018-01-15 15:19:31 +01:00
Christian Grothoff
ff0d4bb6eb
add TALER_EXCHANGE_refund2, make sure fee test initializes all amounts; update ChangeLog 2018-01-01 23:28:19 +01:00
Christian Grothoff
c182b960f8
remove _admin APIs from libtalerexchange 2017-12-14 13:42:07 +01:00
Christian Grothoff
499247a480
fixing #5178 2017-11-29 20:23:08 +01:00
Christian Grothoff
beeece1d6a
add TALER_EXCHANGE_reserve_withdraw2 function for easy withdrawal of tips 2017-10-31 14:45:15 +01:00
Christian Grothoff
2f2930f1ba
major API refactoring, adding planchet generation and coin extraction APIs to the Taler crypto library, thereby simplifying code in withdraw, refresh, tipping, payback and testcases; slight API incompatibilities to previous versions are introduced 2017-10-31 14:02:54 +01:00
Christian Grothoff
b46735fbaf
add argument to TALER_EXCHANGE_check_keys_current() to allow forcing the download 2017-09-13 14:08:11 +02:00
Christian Grothoff
6d7645a99b
theoretically finished implementation of #4840 (/keys cherry picking), but by far not done testing 2017-09-13 01:14:31 +02:00
Christian Grothoff
7aa23a39bd
add support for #4840 (/keys cherry picking) to libtalerexchange 2017-09-12 15:34:38 +02:00
Christian Grothoff
d77c4160ec
implement logic to check protocol version compatibility (#5035) 2017-07-01 14:15:26 +02:00
Christian Grothoff
f048de9782
preparations for #4840 2017-06-29 20:46:52 +02:00
Christian Grothoff
4694810d9d
free auditor data on shutdown (#5050) 2017-06-04 12:13:30 +02:00
Christian Grothoff
1e30d60a25
fixing misc doxygen issues 2017-06-04 11:30:43 +02:00
Christian Grothoff
b217058821
add version to keydata returned by libtalerexchange (#5035) 2017-06-01 23:00:06 +02:00
Florian Dold
85350ced32
rename proposal_data to contract_terms (see #4879) 2017-05-29 01:15:41 +02:00
Christian Grothoff
20aad54c3e
remove dead transfer details field from reserves_in (API, exchangedb, etc.) 2017-05-08 13:18:36 +02:00
Christian Grothoff
27c921c7c4
finished implementing #4956 in principle, but not yet tested 2017-04-20 21:38:02 +02:00
Christian Grothoff
487237381d
fix misc doxygen issues 2017-04-20 07:49:56 +02:00
Christian Grothoff
c15ff78f0c
implementing #4956-support in libtalerexchange 2017-04-19 14:15:48 +02:00
Christian Grothoff
164c125528
introducing closing fee 2017-04-17 14:01:55 +02:00
Christian Grothoff
4d4ac495a4
test case of /payback done twice, handle 403-case in /payback handler, thereby also testing coin-with-payback history case in test logic (fixes #3887) 2017-04-16 02:39:11 +02:00
Christian Grothoff
cc3aa31732
implement #3887-handling in exchange-lib 2017-04-03 22:45:48 +02:00
Christian Grothoff
29a2f9b345
implement rest of exchange logic for #3887 (return payback information in reserve and coin histories) 2017-04-03 16:40:31 +02:00
Christian Grothoff
b293bda4ac
implement DB plugin function to obtain reserve information, migrate logic to simplified API spec (#3887); use plugin API in /payback DB implementation 2017-04-01 23:43:55 +02:00
Christian Grothoff
722577835f
implement /payback-functions in libtalerexchange.so 2017-03-29 15:44:59 +02:00
Christian Grothoff
0e15a99504
implement #4937: allow extraction of fees 2017-03-04 18:45:25 +01:00
Christian Grothoff
6ab67a3a76
implementing #4929 2017-03-04 16:49:33 +01:00
Florian Dold
92246c3e88
remove transaction_id, only one payment per proposal allowed 2017-02-07 15:09:10 +01:00