From f8558c418ee4e4ff6dd5cac1b1711999f8ace20d Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Wed, 3 Jun 2015 12:35:30 +0200
Subject: [PATCH] remarks on #3811

---
 src/include/taler_mintdb_plugin.h   | 2 ++
 src/mintdb/plugin_mintdb_postgres.c | 9 +++++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/include/taler_mintdb_plugin.h b/src/include/taler_mintdb_plugin.h
index b7dc1ff45..054a19177 100644
--- a/src/include/taler_mintdb_plugin.h
+++ b/src/include/taler_mintdb_plugin.h
@@ -862,6 +862,7 @@ struct TALER_MINTDB_Plugin
    * @return #GNUNET_SYSERR upon error; #GNUNET_NO if no coin is found; #GNUNET_OK
    *           if upon succesfullying retrieving the record data info @a
    *           ret_coin_info
+   * @deprecated (#3811)
    */
   int
   (*get_known_coin) (void *cls,
@@ -878,6 +879,7 @@ struct TALER_MINTDB_Plugin
    * @param session the shared database session
    * @param coin_info the public coin info
    * @return #GNUNET_SYSERR upon error; #GNUNET_OK upon success
+   * @deprecated (#3811)
    */
   int
   (*insert_known_coin) (void *cls,
diff --git a/src/mintdb/plugin_mintdb_postgres.c b/src/mintdb/plugin_mintdb_postgres.c
index a54c6b9ce..7982f8be7 100644
--- a/src/mintdb/plugin_mintdb_postgres.c
+++ b/src/mintdb/plugin_mintdb_postgres.c
@@ -280,7 +280,7 @@ postgres_create_tables (void *cls,
 		 " collectable_blindcoins (reserve_pub)");
   /* Table with coins that have been (partially) spent, used to detect
      double-spending.
-     TODO: maybe rename to "spent_coins"? (#3811) */
+     TODO: maybe eliminate, this might be over-normalization (#3811) */
   SQLEXEC("CREATE TABLE IF NOT EXISTS known_coins "
           "(coin_pub BYTEA NOT NULL PRIMARY KEY"
           ",denom_pub BYTEA NOT NULL REFERENCES denominations (pub)"
@@ -523,9 +523,10 @@ postgres_prepare (PGconn *db_conn)
            4, NULL);
   PREPARE ("get_known_coin",
            "SELECT"
-           " denom_pub, denom_sig "
-           "FROM known_coins "
-           "WHERE coin_pub = $1",
+           " denom_pub"
+           ",denom_sig"
+           " FROM known_coins "
+           " WHERE coin_pub=$1",
            1, NULL);
   PREPARE ("insert_known_coin",
            "INSERT INTO known_coins ("