From d559610da76f9bf08983fd576fb17fdfa2cc6252 Mon Sep 17 00:00:00 2001
From: Christian Grothoff <christian@grothoff.org>
Date: Wed, 9 Feb 2022 10:38:02 +0100
Subject: [PATCH] -poison

---
 src/util/crypto.c      | 3 +++
 src/util/denom.c       | 1 -
 src/util/test_crypto.c | 9 +--------
 3 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/src/util/crypto.c b/src/util/crypto.c
index 293ba9688..b80cb53cd 100644
--- a/src/util/crypto.c
+++ b/src/util/crypto.c
@@ -367,6 +367,9 @@ TALER_blinded_planchet_free (struct TALER_BlindedPlanchet *blinded_planchet)
     GNUNET_free (blinded_planchet->details.rsa_blinded_planchet.blinded_msg);
     break;
   case TALER_DENOMINATION_CS:
+    memset (blinded_planchet,
+            0,
+            sizeof (*blinded_planchet));
     /* nothing to do for CS */
     break;
   default:
diff --git a/src/util/denom.c b/src/util/denom.c
index 3e841ce38..4382a9df3 100644
--- a/src/util/denom.c
+++ b/src/util/denom.c
@@ -380,7 +380,6 @@ TALER_denom_pub_verify (const struct TALER_DenominationPublicKey *denom_pub,
     GNUNET_break (0);
     return GNUNET_SYSERR;
   }
-
   switch (denom_pub->cipher)
   {
   case TALER_DENOMINATION_INVALID:
diff --git a/src/util/test_crypto.c b/src/util/test_crypto.c
index 89955ac7e..0681fc865 100644
--- a/src/util/test_crypto.c
+++ b/src/util/test_crypto.c
@@ -1,6 +1,6 @@
 /*
   This file is part of TALER
-  (C) 2015, 2020, 2021 Taler Systems SA
+  (C) 2015, 2020-2022 Taler Systems SA
 
   TALER is free software; you can redistribute it and/or modify it under the
   terms of the GNU General Public License as published by the Free Software
@@ -198,14 +198,11 @@ test_planchets_cs (void)
   GNUNET_CRYPTO_random_block (GNUNET_CRYPTO_QUALITY_STRONG,
                               &ps,
                               sizeof (ps));
-
   GNUNET_assert (GNUNET_OK ==
                  TALER_denom_priv_create (&dk_priv,
                                           &dk_pub,
                                           TALER_DENOMINATION_CS));
-
   alg_values.cipher = TALER_DENOMINATION_CS;
-
   TALER_cs_withdraw_nonce_derive (
     &ps,
     &pd.blinded_planchet.details.cs_blinded_planchet.nonce);
@@ -214,14 +211,12 @@ test_planchets_cs (void)
                    &pd.blinded_planchet.details.cs_blinded_planchet.nonce,
                    &dk_priv,
                    &alg_values.details.cs_values.r_pub_pair));
-
   TALER_planchet_setup_coin_priv (&ps,
                                   &alg_values,
                                   &coin_priv);
   TALER_planchet_blinding_secret_create (&ps,
                                          &alg_values,
                                          &bks);
-
   GNUNET_assert (GNUNET_OK ==
                  TALER_planchet_prepare (&dk_pub,
                                          &alg_values,
@@ -229,7 +224,6 @@ test_planchets_cs (void)
                                          &coin_priv,
                                          &c_hash,
                                          &pd));
-
   GNUNET_assert (GNUNET_OK ==
                  TALER_denom_sign_blinded (&blind_sig,
                                            &dk_priv,
@@ -243,7 +237,6 @@ test_planchets_cs (void)
                                          &c_hash,
                                          &alg_values,
                                          &coin));
-
   TALER_blinded_denom_sig_free (&blind_sig);
   TALER_denom_sig_free (&coin.sig);
   TALER_denom_priv_free (&dk_priv);