taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

do not crash on bogus signature on denomination key

Browse Source
This commit is contained in:
Christian Grothoff 2019-12-07 17:48:39 +01:00
parent 9cbd1cc139
commit d4d590bcda
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/exchange/taler-exchange-httpd_keystate.c
View File

@ -1601,6 +1601,7 @@ reload_public_denoms_cb (void *cls,
{ {
struct ResponseFactoryContext *rfc = cls; struct ResponseFactoryContext *rfc = cls;
struct TALER_EXCHANGEDB_DenominationKeyIssueInformation dki; struct TALER_EXCHANGEDB_DenominationKeyIssueInformation dki;
int ret;
if (rfc->now.abs_value_us > GNUNET_TIME_absolute_ntoh if (rfc->now.abs_value_us > GNUNET_TIME_absolute_ntoh
(issue->properties.expire_legal).abs_value_us) (issue->properties.expire_legal).abs_value_us)
@ -1625,9 +1626,17 @@ reload_public_denoms_cb (void *cls,
dki.denom_pub.rsa_public_key = denom_pub->rsa_public_key; dki.denom_pub.rsa_public_key = denom_pub->rsa_public_key;
dki.issue = *issue; dki.issue = *issue;
/* we can assert here as we checked for duplicates just above */ /* we can assert here as we checked for duplicates just above */
GNUNET_assert (GNUNET_OK == ret = store_in_map (rfc->key_state->denomkey_map,
store_in_map (rfc->key_state->denomkey_map, &dki /* makes a deep copy of dki */);
&dki /* makes a deep copy of dki */)); if (GNUNET_SYSERR == ret)
{
GNUNET_break (0);
GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Signature wrong on denomination key `%s' (skipping)!\n",
GNUNET_h2s (&issue->properties.denom_hash));
return;
}
GNUNET_assert (GNUNET_OK == ret);
} }