taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

three more missing rollbacks found

Browse Source
This commit is contained in:
Christian Grothoff 2016-11-17 11:36:05 +01:00
parent bd096d3928
commit c2ead71600
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/exchange/taler-exchange-httpd_db.c
View File

@ -496,6 +496,8 @@ TEH_DB_execute_refund (struct MHD_Connection *connection,
&dep->amount_with_fee) ) &dep->amount_with_fee) )
{ {
GNUNET_break_op (0); /* cannot refund more than original value */ GNUNET_break_op (0); /* cannot refund more than original value */
TEH_plugin->rollback (TEH_plugin->cls,
session);
TEH_plugin->free_coin_transaction_list (TEH_plugin->cls, TEH_plugin->free_coin_transaction_list (TEH_plugin->cls,
tl); tl);
return TEH_RESPONSE_reply_refund_failure (connection, return TEH_RESPONSE_reply_refund_failure (connection,
@ -513,6 +515,8 @@ TEH_DB_execute_refund (struct MHD_Connection *connection,
/* DKI not found, but we do have a coin with this DK in our database; /* DKI not found, but we do have a coin with this DK in our database;
not good... */ not good... */
GNUNET_break (0); GNUNET_break (0);
TEH_plugin->rollback (TEH_plugin->cls,
session);
TEH_KS_release (mks); TEH_KS_release (mks);
TEH_plugin->free_coin_transaction_list (TEH_plugin->cls, TEH_plugin->free_coin_transaction_list (TEH_plugin->cls,
tl); tl);
@ -732,6 +736,8 @@ execute_reserve_withdraw_transaction (struct MHD_Connection *connection,
{ {
/* did not encounter any wire transfer operations, how can we have a reserve? */ /* did not encounter any wire transfer operations, how can we have a reserve? */
GNUNET_break (0); GNUNET_break (0);
TEH_plugin->rollback (TEH_plugin->cls,
session);
return TEH_RESPONSE_reply_internal_db_error (connection, return TEH_RESPONSE_reply_internal_db_error (connection,
TALER_EC_WITHDRAW_RESERVE_WITHOUT_WIRE_TRANSFER); TALER_EC_WITHDRAW_RESERVE_WITHOUT_WIRE_TRANSFER);
} }