taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-address FIXMEs

Browse Source
This commit is contained in:
Christian Grothoff 2022-02-12 11:24:32 +01:00
parent bc14c215b3
commit c2549e8b1e
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
5 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/gana

@ -1 +1 @@
Subproject commit c12314df0f82e192c6829a9c6cf3e9663b586da1 Subproject commit b81c1622db81c947b102b1fa2075a949f021ad21

3
src/exchange/taler-exchange-httpd_csr.c
View File

@ -68,8 +68,7 @@ TEH_handler_csr (struct TEH_RequestContext *rc,
return TALER_MHD_reply_with_error ( return TALER_MHD_reply_with_error (
rc->connection, rc->connection,
MHD_HTTP_BAD_REQUEST, MHD_HTTP_BAD_REQUEST,
// FIXME: generalize error message TALER_EC_EXCHANGE_GENERIC_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
TALER_EC_EXCHANGE_REFRESHES_REVEAL_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
NULL); NULL);
} }
struct TALER_CsNonce nonces[GNUNET_NZL (csr_requests_num)]; struct TALER_CsNonce nonces[GNUNET_NZL (csr_requests_num)];

2
src/exchange/taler-exchange-httpd_refreshes_reveal.c
View File

@ -705,7 +705,7 @@ handle_refreshes_reveal_json (struct MHD_Connection *connection,
GNUNET_break_op (0); GNUNET_break_op (0);
return TALER_MHD_reply_with_error (connection, return TALER_MHD_reply_with_error (connection,
MHD_HTTP_BAD_REQUEST, MHD_HTTP_BAD_REQUEST,
TALER_EC_EXCHANGE_REFRESHES_REVEAL_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE, TALER_EC_EXCHANGE_GENERIC_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
NULL); NULL);
} }

3
src/exchangedb/plugin_exchangedb_postgres.c
View File

@ -6100,7 +6100,6 @@ postgres_insert_refresh_reveal (
GNUNET_PQ_query_param_auto_from_type (&rrc->orig_coin_link_sig), GNUNET_PQ_query_param_auto_from_type (&rrc->orig_coin_link_sig),
GNUNET_PQ_query_param_auto_from_type (&rrc->h_denom_pub), GNUNET_PQ_query_param_auto_from_type (&rrc->h_denom_pub),
TALER_PQ_query_param_blinded_planchet (&rrc->blinded_planchet), TALER_PQ_query_param_blinded_planchet (&rrc->blinded_planchet),
// FIXME: needed? review link protocol!
TALER_PQ_query_param_exchange_withdraw_values (&rrc->exchange_vals), TALER_PQ_query_param_exchange_withdraw_values (&rrc->exchange_vals),
GNUNET_PQ_query_param_auto_from_type (&rrc->coin_envelope_hash), GNUNET_PQ_query_param_auto_from_type (&rrc->coin_envelope_hash),
TALER_PQ_query_param_blinded_denom_sig (&rrc->coin_sig), TALER_PQ_query_param_blinded_denom_sig (&rrc->coin_sig),
@ -6210,7 +6209,6 @@ add_revealed_coins (void *cls,
&rrc->coin_envelope_hash), &rrc->coin_envelope_hash),
TALER_PQ_result_spec_blinded_planchet ("coin_ev", TALER_PQ_result_spec_blinded_planchet ("coin_ev",
&rrc->blinded_planchet), &rrc->blinded_planchet),
// FIXME: needed? review link protocol!
TALER_PQ_result_spec_exchange_withdraw_values ("ewv", TALER_PQ_result_spec_exchange_withdraw_values ("ewv",
&rrc->exchange_vals), &rrc->exchange_vals),
TALER_PQ_result_spec_blinded_denom_sig ("ev_sig", TALER_PQ_result_spec_blinded_denom_sig ("ev_sig",
@ -6396,7 +6394,6 @@ add_ldl (void *cls,
&pos->ev_sig), &pos->ev_sig),
GNUNET_PQ_result_spec_uint32 ("freshcoin_index", GNUNET_PQ_result_spec_uint32 ("freshcoin_index",
&pos->coin_refresh_offset), &pos->coin_refresh_offset),
// FIXME: needed? review link protocol!
TALER_PQ_result_spec_exchange_withdraw_values ("ewv", TALER_PQ_result_spec_exchange_withdraw_values ("ewv",
&pos->alg_values), &pos->alg_values),
TALER_PQ_result_spec_denom_pub ("denom_pub", TALER_PQ_result_spec_denom_pub ("denom_pub",

1
src/exchangedb/test_exchangedb.c
View File

@ -1480,7 +1480,6 @@ run (void *cls)
&age_hash &age_hash
}; };
// FIXME:
/* Call TALER_denom_blind()/TALER_denom_sign_blinded() twice, once without /* Call TALER_denom_blind()/TALER_denom_sign_blinded() twice, once without
* age_hash, once with age_hash */ * age_hash, once with age_hash */
RND_BLK (&age_hash); RND_BLK (&age_hash);