taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-fix some clang warnings

Browse Source
This commit is contained in:
Christian Grothoff 2022-08-22 00:08:28 +02:00
parent a5b9fce183
commit a199ba7fe6
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/benchmark/taler-aggregator-benchmark.c
View File

@ -504,7 +504,7 @@ run (void *cls,
{ {
struct GNUNET_HashCode seed; struct GNUNET_HashCode seed;
struct TALER_AgeMask mask = { struct TALER_AgeMask mask = {
.bits = 1 || 1 << 8 || 1 << 12 || 1 << 16 || 1 << 18 .bits = 1 | (1 << 8) | (1 << 12) | (1 << 16) | (1 << 18)
}; };
struct TALER_AgeCommitmentProof acp = {0}; struct TALER_AgeCommitmentProof acp = {0};

5
src/exchange/taler-exchange-httpd_batch-withdraw.c
View File

@ -173,7 +173,6 @@ batch_withdraw_transaction (void *cls,
MHD_RESULT *mhd_ret) MHD_RESULT *mhd_ret)
{ {
struct BatchWithdrawContext *wc = cls; struct BatchWithdrawContext *wc = cls;
struct GNUNET_TIME_Timestamp now;
uint64_t ruuid; uint64_t ruuid;
enum GNUNET_DB_QueryStatus qs; enum GNUNET_DB_QueryStatus qs;
bool balance_ok = false; bool balance_ok = false;
@ -213,7 +212,7 @@ batch_withdraw_transaction (void *cls,
} }
wc->kyc.ok = true; wc->kyc.ok = true;
qs = TEH_plugin->do_batch_withdraw (TEH_plugin->cls, qs = TEH_plugin->do_batch_withdraw (TEH_plugin->cls,
now, wc->now,
wc->reserve_pub, wc->reserve_pub,
&wc->batch_total, &wc->batch_total,
&found, &found,
@ -262,7 +261,7 @@ batch_withdraw_transaction (void *cls,
qs = TEH_plugin->do_batch_withdraw_insert (TEH_plugin->cls, qs = TEH_plugin->do_batch_withdraw_insert (TEH_plugin->cls,
nonce, nonce,
&pc->collectable, &pc->collectable,
now, wc->now,
ruuid, ruuid,
&denom_unknown, &denom_unknown,
&conflict, &conflict,

2
src/exchangedb/plugin_exchangedb_postgres.c
View File

@ -10210,6 +10210,7 @@ reserve_expired_cb (void *cls,
ret = GNUNET_SYSERR; ret = GNUNET_SYSERR;
break; break;
} }
// FIXME: ret here is a qs! Bad enum conversion! FIX DESIGN!!!
ret = erc->rec (erc->rec_cls, ret = erc->rec (erc->rec_cls,
&reserve_pub, &reserve_pub,
&remaining_balance, &remaining_balance,
@ -15300,6 +15301,7 @@ postgres_delete_shard_locks (void *cls)
GNUNET_PQ_EXECUTE_STATEMENT_END GNUNET_PQ_EXECUTE_STATEMENT_END
}; };
// FIXME: rval is a GNUNET_GenericReturnValue, not DB status!
return GNUNET_PQ_exec_statements (pg->conn, return GNUNET_PQ_exec_statements (pg->conn,
es); es);
} }

2
src/mhd/mhd_parsing.c
View File

@ -60,7 +60,7 @@ TALER_MHD_parse_post_json (struct MHD_Connection *connection,
GNUNET_break (NULL == *json); GNUNET_break (NULL == *json);
GNUNET_log (GNUNET_ERROR_TYPE_WARNING, GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
"Closing connection, upload too large\n"); "Closing connection, upload too large\n");
return MHD_NO; return GNUNET_SYSERR;
case GNUNET_JSON_PR_JSON_INVALID: case GNUNET_JSON_PR_JSON_INVALID:
GNUNET_break (NULL == *json); GNUNET_break (NULL == *json);
return (MHD_YES == return (MHD_YES ==