major renaming of internal symbols for better consistency

src/exchange/taler-exchange-httpd.c

@@ -189,19 +189,19 @@ handle_post_coins (const struct TEH_RequestHandler *rh,
   } h[] = {
     {
       .op = "deposit",
-      .handler = &TEH_DEPOSIT_handler_deposit
+      .handler = &TEH_handler_deposit
     },
     {
       .op = "melt",
-      .handler = &TEH_REFRESH_handler_melt
+      .handler = &TEH_handler_melt
     },
     {
       .op = "recoup",
-      .handler = &TEH_RECOUP_handler_recoup
+      .handler = &TEH_handler_recoup
     },
     {
       .op = "refund",
-      .handler = &TEH_REFUND_handler_refund
+      .handler = &TEH_handler_refund
     },
     {
       .op = NULL,
@@ -276,8 +276,8 @@ handle_mhd_completion_callback (void *cls,
 
 
 /**
- * Return GNUNET_YES if given a valid correlation ID and
+ * Return #GNUNET_YES if given a valid correlation ID and
- * GNUNET_NO otherwise.
+ * #GNUNET_NO otherwise.
  *
  * @returns #GNUNET_YES iff given a valid correlation ID
  */
@@ -447,7 +447,7 @@ handle_mhd_request (void *cls,
     {
       .url = "robots.txt",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_MHD_handler_static_response,
+      .handler.get = &TEH_handler_static_response,
       .mime_type = "text/plain",
       .data = "User-agent: *\nDisallow: /\n",
       .response_code = MHD_HTTP_OK
@@ -456,7 +456,7 @@ handle_mhd_request (void *cls,
     {
       .url = "",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = TEH_MHD_handler_static_response,
+      .handler.get = TEH_handler_static_response,
       .mime_type = "text/plain",
       .data =
         "Hello, I'm the Taler exchange. This HTTP server is not for humans.\n",
@@ -469,7 +469,7 @@ handle_mhd_request (void *cls,
     {
       .url = "agpl",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_MHD_handler_agpl_redirect
+      .handler.get = &TEH_handler_agpl_redirect
     },
     /* Terms of service */
     {
@@ -487,25 +487,25 @@ handle_mhd_request (void *cls,
     {
       .url = "keys",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_KS_handler_keys,
+      .handler.get = &TEH_handler_keys,
     },
     /* Requests for wiring information */
     {
       .url = "wire",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_WIRE_handler_wire
+      .handler.get = &TEH_handler_wire
     },
     /* Withdrawing coins / interaction with reserves */
     {
       .url = "reserves",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_RESERVE_handler_reserve_status,
+      .handler.get = &TEH_handler_reserves_get,
       .nargs = 1
     },
     {
       .url = "reserves",
       .method = MHD_HTTP_METHOD_POST,
-      .handler.post = &TEH_RESERVE_handler_reserve_withdraw,
+      .handler.post = &TEH_handler_withdraw,
       .nargs = 2
     },
     /* coins */
@@ -518,28 +518,28 @@ handle_mhd_request (void *cls,
     {
       .url = "coins",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = TEH_REFRESH_handler_link,
+      .handler.get = TEH_handler_link,
       .nargs = 2,
     },
     /* refreshing */
     {
       .url = "refreshes",
       .method = MHD_HTTP_METHOD_POST,
-      .handler.post = &TEH_REFRESH_handler_reveal,
+      .handler.post = &TEH_handler_reveal,
       .nargs = 2
     },
     /* tracking transfers */
     {
       .url = "transfers",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_TRACKING_handler_track_transfer,
+      .handler.get = &TEH_handler_transfers_get,
       .nargs = 1
     },
     /* tracking deposits */
     {
       .url = "deposits",
       .method = MHD_HTTP_METHOD_GET,
-      .handler.get = &TEH_TRACKING_handler_track_transaction,
+      .handler.get = &TEH_handler_deposits_get,
       .nargs = 4
     },
     /* mark end of list */
@@ -892,7 +892,7 @@ static int do_terminate;
  * @return child pid
  */
 static pid_t
-run_fake_client ()
+run_fake_client (void)
 {
   pid_t cld;
   char ports[6];
@@ -984,7 +984,7 @@ connection_done (void *cls,
  * @return #GNUNET_OK on success
  */
 static int
-run_single_request ()
+run_single_request (void)
 {
   pid_t cld;
   int status;

src/exchange/taler-exchange-httpd_deposit.c

@@ -393,7 +393,7 @@ check_timestamp_current (struct GNUNET_TIME_Absolute ts)
  * @return MHD result code
   */
 int
-TEH_DEPOSIT_handler_deposit (struct MHD_Connection *connection,
+TEH_handler_deposit (struct MHD_Connection *connection,
                      const struct TALER_CoinSpendPublicKeyP *coin_pub,
                      const json_t *root)
 {

src/exchange/taler-exchange-httpd_deposit.h

@@ -41,7 +41,7 @@
  * @return MHD result code
   */
 int
-TEH_DEPOSIT_handler_deposit (struct MHD_Connection *connection,
+TEH_handler_deposit (struct MHD_Connection *connection,
                      const struct TALER_CoinSpendPublicKeyP *coin_pub,
                      const json_t *root);
 

src/exchange/taler-exchange-httpd_deposits_get.c

@@ -346,7 +346,7 @@ check_and_handle_track_transaction_request (struct MHD_Connection *connection,
  * @return MHD result code
   */
 int
-TEH_TRACKING_handler_track_transaction (const struct TEH_RequestHandler *rh,
+TEH_handler_deposits_get (const struct TEH_RequestHandler *rh,
                           struct MHD_Connection *connection,
                           const char *const args[4])
 {

src/exchange/taler-exchange-httpd_deposits_get.h

@@ -37,7 +37,7 @@
  * @return MHD result code
   */
 int
-TEH_TRACKING_handler_track_transaction (const struct TEH_RequestHandler *rh,
+TEH_handler_deposits_get (const struct TEH_RequestHandler *rh,
                           struct MHD_Connection *connection,
                           const char *const args[4]);
 

src/exchange/taler-exchange-httpd_keystate.c

@@ -2394,7 +2394,7 @@ krd_search_comparator (const void *key,
  * @return MHD result code
  */
 int
-TEH_KS_handler_keys (const struct TEH_RequestHandler *rh,
+TEH_handler_keys (const struct TEH_RequestHandler *rh,
                   struct MHD_Connection *connection,
                   const char *const args[])
 {

src/exchange/taler-exchange-httpd_keystate.h

@@ -192,7 +192,7 @@ TEH_KS_sign (const struct GNUNET_CRYPTO_EccSignaturePurpose *purpose,
  * @return MHD result code
  */
 int
-TEH_KS_handler_keys (const struct TEH_RequestHandler *rh,
+TEH_handler_keys (const struct TEH_RequestHandler *rh,
                   struct MHD_Connection *connection,
                   const char *const args[]);
 

src/exchange/taler-exchange-httpd_link.c

@@ -180,7 +180,7 @@ refresh_link_transaction (void *cls,
  * @return MHD result code
   */
 int
-TEH_REFRESH_handler_link (const struct TEH_RequestHandler *rh,
+TEH_handler_link (const struct TEH_RequestHandler *rh,
                   struct MHD_Connection *connection,
                   const char *const args[2])
 {

src/exchange/taler-exchange-httpd_link.h

@@ -37,7 +37,7 @@
  * @return MHD result code
   */
 int
-TEH_REFRESH_handler_link (const struct TEH_RequestHandler *rh,
+TEH_handler_link (const struct TEH_RequestHandler *rh,
                   struct MHD_Connection *connection,
                   const char *const args[2]);
 

src/exchange/taler-exchange-httpd_melt.c

@@ -588,7 +588,7 @@ check_for_denomination_key (struct MHD_Connection *connection,
  * @return MHD result code
  */
 int
-TEH_REFRESH_handler_melt (struct MHD_Connection *connection,
+TEH_handler_melt (struct MHD_Connection *connection,
                   const struct TALER_CoinSpendPublicKeyP *coin_pub,
                   const json_t *root)
 {

src/exchange/taler-exchange-httpd_melt.h

@@ -40,7 +40,7 @@
  * @return MHD result code
  */
 int
-TEH_REFRESH_handler_melt (struct MHD_Connection *connection,
+TEH_handler_melt (struct MHD_Connection *connection,
                   const struct TALER_CoinSpendPublicKeyP *coin_pub,
                   const json_t *root);
 

src/exchange/taler-exchange-httpd_mhd.c

@@ -43,7 +43,7 @@
  * @return MHD result code
  */
 int
-TEH_MHD_handler_static_response (const struct TEH_RequestHandler *rh,
+TEH_handler_static_response (const struct TEH_RequestHandler *rh,
                              struct MHD_Connection *connection,
                              const char *const args[])
 {
@@ -86,7 +86,7 @@ TEH_MHD_handler_static_response (const struct TEH_RequestHandler *rh,
  * @return MHD result code
  */
 int
-TEH_MHD_handler_agpl_redirect (const struct TEH_RequestHandler *rh,
+TEH_handler_agpl_redirect (const struct TEH_RequestHandler *rh,
                            struct MHD_Connection *connection,
                            const char *const args[])
 {
@@ -107,7 +107,7 @@ TEH_MHD_handler_agpl_redirect (const struct TEH_RequestHandler *rh,
  * @return MHD result code
  */
 int
-TEH_MHD_handler_send_json_pack_error (const struct TEH_RequestHandler *rh,
+TEH_handler_send_json_pack_error (const struct TEH_RequestHandler *rh,
                                   struct MHD_Connection *connection,
                                   const char *const args[])
 {

src/exchange/taler-exchange-httpd_mhd.h

@@ -38,7 +38,7 @@
  * @return MHD result code
  */
 int
-TEH_MHD_handler_static_response (const struct TEH_RequestHandler *rh,
+TEH_handler_static_response (const struct TEH_RequestHandler *rh,
                              struct MHD_Connection *connection,
                              const char *const args[]);
 
@@ -53,7 +53,7 @@ TEH_MHD_handler_static_response (const struct TEH_RequestHandler *rh,
  * @return MHD result code
  */
 int
-TEH_MHD_handler_agpl_redirect (const struct TEH_RequestHandler *rh,
+TEH_handler_agpl_redirect (const struct TEH_RequestHandler *rh,
                            struct MHD_Connection *connection,
                            const char *const args[]);
 
@@ -68,7 +68,7 @@ TEH_MHD_handler_agpl_redirect (const struct TEH_RequestHandler *rh,
  * @return MHD result code
  */
 int
-TEH_MHD_handler_send_json_pack_error (const struct TEH_RequestHandler *rh,
+TEH_handler_send_json_pack_error (const struct TEH_RequestHandler *rh,
                                   struct MHD_Connection *connection,
                                   const char *const args[]);
 

src/exchange/taler-exchange-httpd_recoup.c

@@ -573,7 +573,7 @@ verify_and_execute_recoup (struct MHD_Connection *connection,
  * @return MHD result code
   */
 int
-TEH_RECOUP_handler_recoup (struct MHD_Connection *connection,
+TEH_handler_recoup (struct MHD_Connection *connection,
                     const struct TALER_CoinSpendPublicKeyP *coin_pub,
                     const json_t *root)
 {

src/exchange/taler-exchange-httpd_recoup.h

@@ -38,7 +38,7 @@
  * @return MHD result code
   */
 int
-TEH_RECOUP_handler_recoup (struct MHD_Connection *connection,
+TEH_handler_recoup (struct MHD_Connection *connection,
                     const struct TALER_CoinSpendPublicKeyP *coin_pub,
                     const json_t *root);
 

src/exchange/taler-exchange-httpd_refreshes_reveal.c

@@ -899,7 +899,7 @@ handle_refresh_reveal_json (struct MHD_Connection *connection,
  * @return MHD result code
  */
 int
-TEH_REFRESH_handler_reveal (const struct TEH_RequestHandler *rh,
+TEH_handler_reveal (const struct TEH_RequestHandler *rh,
                     struct MHD_Connection *connection,
                     const json_t *root,
                     const char *const args[2])

src/exchange/taler-exchange-httpd_refreshes_reveal.h

@@ -44,7 +44,7 @@
  * @return MHD result code
  */
 int
-TEH_REFRESH_handler_reveal (const struct TEH_RequestHandler *rh,
+TEH_handler_reveal (const struct TEH_RequestHandler *rh,
                     struct MHD_Connection *connection,
                     const json_t *root,
                     const char *const args[2]);

src/exchange/taler-exchange-httpd_refund.c

@@ -543,7 +543,7 @@ verify_and_execute_refund (struct MHD_Connection *connection,
  * @return MHD result code
   */
 int
-TEH_REFUND_handler_refund (struct MHD_Connection *connection,
+TEH_handler_refund (struct MHD_Connection *connection,
                     const struct TALER_CoinSpendPublicKeyP *coin_pub,
                     const json_t *root)
 {

src/exchange/taler-exchange-httpd_refund.h

@@ -40,7 +40,7 @@
  * @return MHD result code
   */
 int
-TEH_REFUND_handler_refund (struct MHD_Connection *connection,
+TEH_handler_refund (struct MHD_Connection *connection,
                     const struct TALER_CoinSpendPublicKeyP *coin_pub,
                     const json_t *root);
 

src/exchange/taler-exchange-httpd_reserves_get.c

@@ -125,7 +125,7 @@ reserve_status_transaction (void *cls,
  * @return MHD result code
  */
 int
-TEH_RESERVE_handler_reserve_status (const struct TEH_RequestHandler *rh,
+TEH_handler_reserves_get (const struct TEH_RequestHandler *rh,
                           struct MHD_Connection *connection,
                           const char *const args[1])
 {

src/exchange/taler-exchange-httpd_reserves_get.h

@@ -39,7 +39,7 @@
  * @return MHD result code
  */
 int
-TEH_RESERVE_handler_reserve_status (const struct TEH_RequestHandler *rh,
+TEH_handler_reserves_get (const struct TEH_RequestHandler *rh,
                           struct MHD_Connection *connection,
                           const char *const args[1]);
 

src/exchange/taler-exchange-httpd_transfers_get.c

@@ -490,7 +490,7 @@ free_ctx (struct WtidTransactionContext *ctx)
  * @return MHD result code
  */
 int
-TEH_TRACKING_handler_track_transfer (const struct TEH_RequestHandler *rh,
+TEH_handler_transfers_get (const struct TEH_RequestHandler *rh,
                            struct MHD_Connection *connection,
                            const char *const args[1])
 {

src/exchange/taler-exchange-httpd_transfers_get.h

@@ -35,7 +35,7 @@
  * @return MHD result code
  */
 int
-TEH_TRACKING_handler_track_transfer (const struct TEH_RequestHandler *rh,
+TEH_handler_transfers_get (const struct TEH_RequestHandler *rh,
                            struct MHD_Connection *connection,
                            const char *const args[1]);
 

src/exchange/taler-exchange-httpd_wire.c

@@ -128,7 +128,7 @@ TEH_WIRE_get_fees (const char *method)
  * @return MHD result code
   */
 int
-TEH_WIRE_handler_wire (const struct TEH_RequestHandler *rh,
+TEH_handler_wire (const struct TEH_RequestHandler *rh,
                   struct MHD_Connection *connection,
                   const char *const args[])
 {

src/exchange/taler-exchange-httpd_wire.h

@@ -55,7 +55,7 @@ TEH_WIRE_get_fees (const char *method);
  * @return MHD result code
  */
 int
-TEH_WIRE_handler_wire (const struct TEH_RequestHandler *rh,
+TEH_handler_wire (const struct TEH_RequestHandler *rh,
                   struct MHD_Connection *connection,
                   const char *const args[]);
 

src/exchange/taler-exchange-httpd_withdraw.c

@@ -360,7 +360,7 @@ withdraw_transaction (void *cls,
  * @return MHD result code
  */
 int
-TEH_RESERVE_handler_reserve_withdraw (const struct TEH_RequestHandler *rh,
+TEH_handler_withdraw (const struct TEH_RequestHandler *rh,
                       struct MHD_Connection *connection,
                       const json_t *root,
                       const char *const args[2])

src/exchange/taler-exchange-httpd_withdraw.h

@@ -43,7 +43,7 @@
  * @return MHD result code
   */
 int
-TEH_RESERVE_handler_reserve_withdraw (const struct TEH_RequestHandler *rh,
+TEH_handler_withdraw (const struct TEH_RequestHandler *rh,
                       struct MHD_Connection *connection,
                       const json_t *root,
                       const char *const args[2]);