taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-fix leaks

Browse Source
This commit is contained in:
Christian Grothoff 2022-06-29 14:06:37 +02:00
parent 60a30b1c75
commit 9902e88b2d
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/exchange/taler-exchange-httpd_purses_create.c
View File

@ -440,7 +440,6 @@ parse_coin (struct MHD_Connection *connection,
coin, coin,
jcoin))) jcoin)))
return iret; return iret;
if (GNUNET_OK != if (GNUNET_OK !=
(iret = TEH_common_deposit_check_purse_deposit ( (iret = TEH_common_deposit_check_purse_deposit (
connection, connection,
@ -594,6 +593,8 @@ TEH_handler_purses_create (
if (GNUNET_OK != res) if (GNUNET_OK != res)
{ {
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<idx; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return (GNUNET_NO == res) ? MHD_YES : MHD_NO; return (GNUNET_NO == res) ? MHD_YES : MHD_NO;
} }
@ -624,6 +625,8 @@ TEH_handler_purses_create (
{ {
TALER_LOG_WARNING ("Invalid signature on /purses/$PID/create request\n"); TALER_LOG_WARNING ("Invalid signature on /purses/$PID/create request\n");
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return TALER_MHD_reply_with_error (connection, return TALER_MHD_reply_with_error (connection,
MHD_HTTP_FORBIDDEN, MHD_HTTP_FORBIDDEN,
@ -640,6 +643,8 @@ TEH_handler_purses_create (
{ {
TALER_LOG_WARNING ("Invalid signature on /purses/$PID/create request\n"); TALER_LOG_WARNING ("Invalid signature on /purses/$PID/create request\n");
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return TALER_MHD_reply_with_error (connection, return TALER_MHD_reply_with_error (connection,
MHD_HTTP_FORBIDDEN, MHD_HTTP_FORBIDDEN,
@ -653,6 +658,8 @@ TEH_handler_purses_create (
{ {
GNUNET_break (0); GNUNET_break (0);
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return TALER_MHD_reply_with_error (connection, return TALER_MHD_reply_with_error (connection,
MHD_HTTP_INTERNAL_SERVER_ERROR, MHD_HTTP_INTERNAL_SERVER_ERROR,
@ -673,6 +680,8 @@ TEH_handler_purses_create (
&pcc)) &pcc))
{ {
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return mhd_ret; return mhd_ret;
} }
@ -684,6 +693,8 @@ TEH_handler_purses_create (
res = reply_create_success (connection, res = reply_create_success (connection,
&pcc); &pcc);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
return res; return res;

8
src/exchange/taler-exchange-httpd_purses_deposit.c
View File

@ -415,6 +415,8 @@ TEH_handler_purses_deposit (
if (GNUNET_OK != res) if (GNUNET_OK != res)
{ {
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<idx; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return (GNUNET_NO == res) ? MHD_YES : MHD_NO; return (GNUNET_NO == res) ? MHD_YES : MHD_NO;
} }
@ -425,6 +427,8 @@ TEH_handler_purses_deposit (
{ {
GNUNET_break (0); GNUNET_break (0);
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return TALER_MHD_reply_with_error (connection, return TALER_MHD_reply_with_error (connection,
MHD_HTTP_INTERNAL_SERVER_ERROR, MHD_HTTP_INTERNAL_SERVER_ERROR,
@ -445,6 +449,8 @@ TEH_handler_purses_deposit (
&pcc)) &pcc))
{ {
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
return mhd_ret; return mhd_ret;
} }
@ -471,6 +477,8 @@ TEH_handler_purses_deposit (
res = reply_deposit_success (connection, res = reply_deposit_success (connection,
&pcc); &pcc);
for (unsigned int i = 0; i<pcc.num_coins; i++)
TEH_common_deposit_free_coin (&pcc.coins[i]);
GNUNET_free (pcc.coins); GNUNET_free (pcc.coins);
GNUNET_JSON_parse_free (spec); GNUNET_JSON_parse_free (spec);
return res; return res;