taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

-actually, commit phase does take care of this

Browse Source
This commit is contained in:
Christian Grothoff 2022-02-14 23:15:29 +01:00
parent bd77bcb52d
commit 8ecbdeb55b
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/exchange/taler-exchange-httpd_refreshes_reveal.c
View File

@ -634,13 +634,6 @@ resolve_refreshes_reveal_denominations (struct MHD_Connection *connection,
rrc->blinded_planchet = rcds[i].blinded_planchet; rrc->blinded_planchet = rcds[i].blinded_planchet;
} }
// FIXME: in CS-case, we MUST check if signatures
// already exist under the given nonce
// (TODO: check: refresh session hash OK?), and if so,
// we MUST return the existing signatures (c0/c1 may have changed!)
// and MUST NOT return the fresh signatures!
// => change this to a 'do_refresh_reveal' and
// change SQL to return existing signatures (if any)!
qs = TEH_plugin->insert_refresh_reveal (TEH_plugin->cls, qs = TEH_plugin->insert_refresh_reveal (TEH_plugin->cls,
melt_serial_id, melt_serial_id,
num_fresh_coins, num_fresh_coins,

4
src/util/denom.c
View File

@ -806,8 +806,8 @@ TALER_coin_ev_hash (const struct TALER_BlindedPlanchet *blinded_planchet,
blinded_planchet->details.rsa_blinded_planchet.blinded_msg_size); blinded_planchet->details.rsa_blinded_planchet.blinded_msg_size);
break; break;
case TALER_DENOMINATION_CS: case TALER_DENOMINATION_CS:
// FIMXE: c-values MUST NOT be included in idempotency check // FIXME: c-values MUST NOT be included in idempotency check
// during withdraw/refresh, but right now they are!!! // during withdraw (or recoup), but right now they are!!!
GNUNET_CRYPTO_hash_context_read ( GNUNET_CRYPTO_hash_context_read (
hash_context, hash_context,
&blinded_planchet->details.cs_blinded_planchet.c[0], &blinded_planchet->details.cs_blinded_planchet.c[0],