taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

point out duplication, fix hard-coded '2'

Browse Source
This commit is contained in:
Christian Grothoff 2020-01-17 20:50:39 +01:00
parent 33877b2c55
commit 81d3b454e1
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/taler_testing_lib.h
View File

@ -276,6 +276,8 @@ struct TALER_TESTING_BankConfiguration
/** /**
* Base URL of the exchange's bank account. Basically * Base URL of the exchange's bank account. Basically
* @e bank_url plus the exchange account. * @e bank_url plus the exchange account.
*
* FIXME: remove? This duplicates exchange_auth.wire_gateway_url!
*/ */
char *exchange_account_url; char *exchange_account_url;

11
src/lib/testing_api_helpers_bank.c
View File

@ -403,17 +403,19 @@ TALER_TESTING_prepare_fakebank (const char *config_filename,
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
bc->exchange_auth.method = TALER_BANK_AUTH_NONE; bc->exchange_auth.method = TALER_BANK_AUTH_NONE;
// FIXME: we should not hardcode exchange account number "2"
GNUNET_asprintf (&bc->exchange_auth.wire_gateway_url, GNUNET_asprintf (&bc->exchange_auth.wire_gateway_url,
"http://localhost:%u/2/", "http://localhost:%u/%s/",
(unsigned int) fakebank_port); (unsigned int) fakebank_port,
EXCHANGE_ACCOUNT_NAME);
GNUNET_log (GNUNET_ERROR_TYPE_INFO, GNUNET_log (GNUNET_ERROR_TYPE_INFO,
"Using fakebank %s on port %u\n", "Using fakebank %s on port %u\n",
bc->exchange_auth.wire_gateway_url, bc->exchange_auth.wire_gateway_url,
(unsigned int) fakebank_port); (unsigned int) fakebank_port);
GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Fakebank port from config: %u\n", GNUNET_log (GNUNET_ERROR_TYPE_INFO,
"Fakebank port from config: %u\n",
(unsigned int) fakebank_port); (unsigned int) fakebank_port);
GNUNET_CONFIGURATION_destroy (cfg); GNUNET_CONFIGURATION_destroy (cfg);
@ -425,6 +427,7 @@ TALER_TESTING_prepare_fakebank (const char *config_filename,
bc->bank_url = NULL; bc->bank_url = NULL;
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
/* FIXME: this duplicates bc->exchange_auth.wire_gateway_url */
GNUNET_asprintf (&bc->exchange_account_url, GNUNET_asprintf (&bc->exchange_account_url,
"http://localhost:%u/%s/", "http://localhost:%u/%s/",
fakebank_port, fakebank_port,