taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

add references to Mantis bugs to TODO/FIXME comments in code

Browse Source
This commit is contained in:
Christian Grothoff 2017-10-12 20:56:16 +02:00
parent cb13afaf54
commit 7a232a0941
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
3 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/auditor/taler-auditor.c
View File

@ -154,7 +154,7 @@ report_row_inconsistency (const char *table,
uint64_t rowid, uint64_t rowid,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Database inconsistency detected in table %s at row %llu: %s\n", "Database inconsistency detected in table %s at row %llu: %s\n",
table, table,
@ -176,7 +176,7 @@ report_row_minor_inconsistency (const char *table,
uint64_t rowid, uint64_t rowid,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Minor inconsistency detected in table %s at row %llu: %s\n", "Minor inconsistency detected in table %s at row %llu: %s\n",
table, table,
@ -199,7 +199,7 @@ report_reserve_inconsistency (const struct TALER_ReservePublicKeyP *reserve_pub,
const struct TALER_Amount *observed, const struct TALER_Amount *observed,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file, include amounts. // TODO (#4963): implement proper reporting logic writing to file, include amounts.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Reserve inconsistency detected affecting reserve %s: %s\n", "Reserve inconsistency detected affecting reserve %s: %s\n",
TALER_B2S (reserve_pub), TALER_B2S (reserve_pub),
@ -223,7 +223,7 @@ report_wire_out_inconsistency (const json_t *destination,
const struct TALER_Amount *observed, const struct TALER_Amount *observed,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file, include amounts. // TODO (#4963): implement proper reporting logic writing to file, include amounts.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Wire out inconsistency detected: %s\n", "Wire out inconsistency detected: %s\n",
diagnostic); diagnostic);
@ -244,7 +244,7 @@ report_coin_inconsistency (const struct TALER_CoinSpendPublicKeyP *coin_pub,
const struct TALER_Amount *observed, const struct TALER_Amount *observed,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file, include amounts. // TODO (#4963): implement proper reporting logic writing to file, include amounts.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Coin inconsistency detected: %s\n", "Coin inconsistency detected: %s\n",
diagnostic); diagnostic);
@ -271,7 +271,7 @@ static void
report_reserve_balance (const struct TALER_Amount *total_balance, report_reserve_balance (const struct TALER_Amount *total_balance,
const struct TALER_Amount *total_fee_balance) const struct TALER_Amount *total_fee_balance)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE, GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE,
"Escrow balance to be held for reserves is %s\n", "Escrow balance to be held for reserves is %s\n",
TALER_amount2s (total_balance)); TALER_amount2s (total_balance));
@ -294,7 +294,7 @@ report_reserve_balance (const struct TALER_Amount *total_balance,
static void static void
report_aggregation_fee_balance (const struct TALER_Amount *total_fee_balance) report_aggregation_fee_balance (const struct TALER_Amount *total_fee_balance)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE, GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE,
"Aggregation fees income is %s\n", "Aggregation fees income is %s\n",
TALER_amount2s (total_fee_balance)); TALER_amount2s (total_fee_balance));
@ -317,7 +317,7 @@ report_denomination_balance (const struct TALER_Amount *total_balance,
const struct TALER_Amount *melt_fees, const struct TALER_Amount *melt_fees,
const struct TALER_Amount *refund_fees) const struct TALER_Amount *refund_fees)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963/4962): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE, GNUNET_log (GNUNET_ERROR_TYPE_MESSAGE,
"Escrow balance for issued coins is %s\n", "Escrow balance for issued coins is %s\n",
TALER_amount2s (total_balance)); TALER_amount2s (total_balance));
@ -2125,7 +2125,7 @@ get_wire_fee (struct AggregationContext *ac,
pos->prev, pos->prev,
wfi); wfi);
/* Check non-overlaping fee invariant */ /* Check non-overlaping fee invariant */
/* TODO: maybe report problems more nicely? */ /* TODO (#4963): maybe report problems more nicely? */
if (NULL != wfi->prev) if (NULL != wfi->prev)
GNUNET_break (wfi->prev->end_date.abs_value_us <= wfi->start_date.abs_value_us); GNUNET_break (wfi->prev->end_date.abs_value_us <= wfi->start_date.abs_value_us);
if (NULL != wfi->next) if (NULL != wfi->next)

12
src/auditor/taler-wire-auditor.c
View File

@ -295,7 +295,7 @@ report_row_inconsistency (const char *table,
uint64_t rowid, uint64_t rowid,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Database inconsistency detected in table %s at row %llu: %s\n", "Database inconsistency detected in table %s at row %llu: %s\n",
table, table,
@ -317,7 +317,7 @@ report_row_minor_inconsistency (const char *table,
uint64_t rowid, uint64_t rowid,
const char *diagnostic) const char *diagnostic)
{ {
// TODO: implement proper reporting logic writing to file. // TODO (#4963): implement proper reporting logic writing to file.
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Minor inconsistency detected in table %s at row %llu: %s\n", "Minor inconsistency detected in table %s at row %llu: %s\n",
table, table,
@ -451,7 +451,7 @@ wire_out_cb (void *cls,
&key); &key);
if (NULL == roi) if (NULL == roi)
{ {
/* FIXME: do proper logging! */ /* FIXME (#4963): do proper logging! */
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Failed to find wire transfer `%s' over %s at `%s' in exchange database!\n", "Failed to find wire transfer `%s' over %s at `%s' in exchange database!\n",
TALER_B2S (wtid), TALER_B2S (wtid),
@ -509,7 +509,7 @@ complain_out_not_found (void *cls,
{ {
struct ReserveOutInfo *roi = value; struct ReserveOutInfo *roi = value;
/* FIXME: log more precisely which wire transfer (and amount) /* FIXME (#4963): log more precisely which wire transfer (and amount)
is bogus. */ is bogus. */
report_row_inconsistency ("reserves_out", report_row_inconsistency ("reserves_out",
UINT64_MAX, UINT64_MAX,
@ -585,12 +585,12 @@ history_debit_cb (void *cls,
return GNUNET_OK; return GNUNET_OK;
} }
roi = GNUNET_new (struct ReserveOutInfo); roi = GNUNET_new (struct ReserveOutInfo);
GNUNET_CRYPTO_hash (&details->reserve_pub, /* FIXME: missnomer */ GNUNET_CRYPTO_hash (&details->reserve_pub, /* FIXME (#5077): missnomer */
sizeof (details->reserve_pub), sizeof (details->reserve_pub),
&roi->subject_hash); &roi->subject_hash);
roi->details.amount = details->amount; roi->details.amount = details->amount;
roi->details.execution_date = details->execution_date; roi->details.execution_date = details->execution_date;
roi->details.reserve_pub = details->reserve_pub; /* FIXME: missnomer & redundant */ roi->details.reserve_pub = details->reserve_pub; /* FIXME (#5077): missnomer & redundant */
roi->details.account_details = json_incref ((json_t *) details->account_details); roi->details.account_details = json_incref ((json_t *) details->account_details);
if (GNUNET_OK != if (GNUNET_OK !=
GNUNET_CONTAINER_multihashmap_put (out_map, GNUNET_CONTAINER_multihashmap_put (out_map,

2
src/include/taler_wire_plugin.h
View File

@ -60,7 +60,7 @@ struct TALER_WIRE_TransferDetails
/** /**
* Reserve public key that was encoded in the wire transfer subject. * Reserve public key that was encoded in the wire transfer subject.
* FIXME: this is incorrect for *outgoing* wire transfers. * FIXME (#5077): this is incorrect for *outgoing* wire transfers.
* Maybe use `struct TALER_WireTransferIdentifierRawP` here instead? * Maybe use `struct TALER_WireTransferIdentifierRawP` here instead?
* OTOH, we might want to make this even more generic in case of * OTOH, we might want to make this even more generic in case of
* invalid transfers, so that we can capture those as well! * invalid transfers, so that we can capture those as well!