-add missing asserts, fix logic issue

This commit is contained in:
Christian Grothoff 2022-10-22 00:14:20 +02:00
parent 28969f415e
commit 6e56693071
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
4 changed files with 24 additions and 18 deletions

View File

@ -283,6 +283,7 @@ add_deposit (const struct Merchant *m)
d.coin.denom_pub_hash = h_denom_pub; d.coin.denom_pub_hash = h_denom_pub;
d.coin.denom_sig = denom_sig; d.coin.denom_sig = denom_sig;
RANDOMIZE (&d.h_contract_terms); RANDOMIZE (&d.h_contract_terms);
d.coin.no_age_commitment = true;
memset (&d.coin.h_age_commitment, memset (&d.coin.h_age_commitment,
0, 0,
sizeof (d.coin.h_age_commitment)); sizeof (d.coin.h_age_commitment));

View File

@ -301,21 +301,21 @@ TEH_handler_kyc_proof (
TALER_EC_EXCHANGE_KYC_GENERIC_LOGIC_UNKNOWN, TALER_EC_EXCHANGE_KYC_GENERIC_LOGIC_UNKNOWN,
args[1]); args[1]);
} }
if (0 != strcmp (args[1],
kpc->provider_section))
{
GNUNET_break_op (0);
return TALER_MHD_reply_with_error (rc->connection,
MHD_HTTP_BAD_REQUEST,
TALER_EC_GENERIC_PARAMETER_MALFORMED,
"PROVIDER_SECTION");
}
if (NULL != kpc->provider_section) if (NULL != kpc->provider_section)
{ {
enum GNUNET_DB_QueryStatus qs; enum GNUNET_DB_QueryStatus qs;
struct GNUNET_TIME_Absolute expiration; struct GNUNET_TIME_Absolute expiration;
if (0 != strcmp (args[1],
kpc->provider_section))
{
GNUNET_break_op (0);
return TALER_MHD_reply_with_error (rc->connection,
MHD_HTTP_BAD_REQUEST,
TALER_EC_GENERIC_PARAMETER_MALFORMED,
"PROVIDER_SECTION");
}
qs = TEH_plugin->lookup_kyc_process_by_account ( qs = TEH_plugin->lookup_kyc_process_by_account (
TEH_plugin->cls, TEH_plugin->cls,
kpc->provider_section, kpc->provider_section,

View File

@ -613,8 +613,9 @@ TEH_handler_reserves_purse (
if (no_purse_fee) if (no_purse_fee)
{ {
rpc.flags = TALER_WAMF_MODE_CREATE_FROM_PURSE_QUOTA; rpc.flags = TALER_WAMF_MODE_CREATE_FROM_PURSE_QUOTA;
TALER_amount_set_zero (TEH_currency, GNUNET_assert (GNUNET_OK ==
&rpc.purse_fee); TALER_amount_set_zero (TEH_currency,
&rpc.purse_fee));
} }
else else
{ {

View File

@ -709,15 +709,19 @@ TALER_TESTING_cmd_deposit_with_ref (const char *label,
GNUNET_assert (0); GNUNET_assert (0);
} }
ds->wallet_timestamp = GNUNET_TIME_timestamp_get (); ds->wallet_timestamp = GNUNET_TIME_timestamp_get ();
json_object_set_new (ds->contract_terms, GNUNET_assert (0 ==
"timestamp", json_object_set_new (ds->contract_terms,
GNUNET_JSON_from_timestamp (ds->wallet_timestamp)); "timestamp",
GNUNET_JSON_from_timestamp (
ds->wallet_timestamp)));
if (0 != refund_deadline.rel_value_us) if (0 != refund_deadline.rel_value_us)
{ {
ds->refund_deadline = GNUNET_TIME_relative_to_timestamp (refund_deadline); ds->refund_deadline = GNUNET_TIME_relative_to_timestamp (refund_deadline);
json_object_set_new (ds->contract_terms, GNUNET_assert (0 ==
"refund_deadline", json_object_set_new (ds->contract_terms,
GNUNET_JSON_from_timestamp (ds->refund_deadline)); "refund_deadline",
GNUNET_JSON_from_timestamp (
ds->refund_deadline)));
} }
GNUNET_assert (GNUNET_OK == GNUNET_assert (GNUNET_OK ==
TALER_string_to_amount (amount, TALER_string_to_amount (amount,