taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Addressing #5332

Browse Source
This commit is contained in:
Marcello Stanisci 2018-07-02 11:13:28 +02:00
parent bfdd05196b
commit 562b2cd180
No known key found for this signature in database
GPG Key ID: 8D526861953F4C0F
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/exchange-lib/testing_api_cmd_deposit.c
View File

@ -225,9 +225,6 @@ deposit_run (void *cls,
ds->merchant_priv.eddsa_priv = *merchant_priv; ds->merchant_priv.eddsa_priv = *merchant_priv;
GNUNET_free (merchant_priv); GNUNET_free (merchant_priv);
/* FIXME: this looks very odd: why take times as relatives,
* just to convert them to absolutes soon after? */
if (0 != ds->refund_deadline.rel_value_us) if (0 != ds->refund_deadline.rel_value_us)
{ {
refund_deadline = GNUNET_TIME_relative_to_absolute refund_deadline = GNUNET_TIME_relative_to_absolute
@ -402,6 +399,8 @@ deposit_traits (void *cls,
* @param contract_terms contract terms to be signed over by the * @param contract_terms contract terms to be signed over by the
* coin. * coin.
* @param refund_deadline refund deadline, zero means 'no refunds'. * @param refund_deadline refund deadline, zero means 'no refunds'.
* Note, if time were absolute, then it would have come
* one day and disrupt tests meaning.
* @param amount how much is going to be deposited. * @param amount how much is going to be deposited.
* @param expected_response_code expected HTTP response code. * @param expected_response_code expected HTTP response code.
* *

11
src/exchange-lib/testing_api_cmd_fakebank_transfer.c
View File

@ -101,7 +101,10 @@ struct FakebankTransferState
uint64_t serial_id; uint64_t serial_id;
/** /**
* Exchange URL. FIXME: explaing is needed. * Exchange URL. This value is fed to the bank when requesting
* the wire transfer; note: the bank needs it because a merchant
* might want to know which exchange performed a wire transfer to
* them, just by looking at bank records.
*/ */
const char *exchange_url; const char *exchange_url;
@ -381,8 +384,6 @@ fakebank_transfer_traits (void *cls,
* debit_account_no at the bank. * debit_account_no at the bank.
* @param auth_password password for @a auth_username. * @param auth_password password for @a auth_username.
* @param exchange_url which exchange is involved in this transfer. * @param exchange_url which exchange is involved in this transfer.
* This data is used for tracking purposes (FIXME: explain
* _how_).
* *
* @return the command. * @return the command.
*/ */
@ -444,8 +445,6 @@ TALER_TESTING_cmd_fakebank_transfer
* @param auth_password password for @a auth_username. * @param auth_password password for @a auth_username.
* @param subject wire transfer's subject line. * @param subject wire transfer's subject line.
* @param exchange_url which exchange is involved in this transfer. * @param exchange_url which exchange is involved in this transfer.
* This data is used for tracking purposes (FIXME: explain
* _how_).
* *
* @return the command. * @return the command.
*/ */
@ -581,8 +580,6 @@ TALER_TESTING_cmd_fakebank_transfer_with_ref
* key of the tipping reserve. This data will then used to * key of the tipping reserve. This data will then used to
* construct the wire transfer subject line. * construct the wire transfer subject line.
* @param exchange_url which exchange is involved in this transfer. * @param exchange_url which exchange is involved in this transfer.
* This data is used for tracking purposes (FIXME: explain
* _how_).
* @param config_filename configuration file to use. * @param config_filename configuration file to use.
* *
* @return the command. * @return the command.