taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix use after free

Browse Source
This commit is contained in:
Christian Grothoff 2020-01-16 20:44:35 +01:00
parent 1e697eb1fe
commit 54fdb3741d
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/testing_api_helpers_bank.c
View File

@ -273,7 +273,6 @@ TALER_TESTING_prepare_bank (const char *config_filename,
GNUNET_break (0); GNUNET_break (0);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
GNUNET_CONFIGURATION_destroy (cfg);
if (GNUNET_OK != if (GNUNET_OK !=
GNUNET_NETWORK_test_port_free (IPPROTO_TCP, GNUNET_NETWORK_test_port_free (IPPROTO_TCP,
@ -284,6 +283,7 @@ TALER_TESTING_prepare_bank (const char *config_filename,
port); port);
GNUNET_break (0); GNUNET_break (0);
GNUNET_free (database); GNUNET_free (database);
GNUNET_CONFIGURATION_destroy (cfg);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
@ -304,6 +304,7 @@ TALER_TESTING_prepare_bank (const char *config_filename,
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Failed to flush the bank db.\n"); "Failed to flush the bank db.\n");
GNUNET_free (database); GNUNET_free (database);
GNUNET_CONFIGURATION_destroy (cfg);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
GNUNET_free (database); GNUNET_free (database);
@ -315,6 +316,7 @@ TALER_TESTING_prepare_bank (const char *config_filename,
{ {
GNUNET_OS_process_destroy (dbreset_proc); GNUNET_OS_process_destroy (dbreset_proc);
GNUNET_break (0); GNUNET_break (0);
GNUNET_CONFIGURATION_destroy (cfg);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
if ( (type == GNUNET_OS_PROCESS_EXITED) && if ( (type == GNUNET_OS_PROCESS_EXITED) &&
@ -323,6 +325,7 @@ TALER_TESTING_prepare_bank (const char *config_filename,
fprintf (stderr, fprintf (stderr,
"Failed to setup database\n"); "Failed to setup database\n");
GNUNET_break (0); GNUNET_break (0);
GNUNET_CONFIGURATION_destroy (cfg);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
if ( (type != GNUNET_OS_PROCESS_EXITED) || if ( (type != GNUNET_OS_PROCESS_EXITED) ||
@ -331,6 +334,7 @@ TALER_TESTING_prepare_bank (const char *config_filename,
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Unexpected error running `taler-bank-manage django flush'!\n"); "Unexpected error running `taler-bank-manage django flush'!\n");
GNUNET_break (0); GNUNET_break (0);
GNUNET_CONFIGURATION_destroy (cfg);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
GNUNET_OS_process_destroy (dbreset_proc); GNUNET_OS_process_destroy (dbreset_proc);
@ -340,8 +344,10 @@ TALER_TESTING_prepare_bank (const char *config_filename,
&bc->exchange_auth)) &bc->exchange_auth))
{ {
GNUNET_break (0); GNUNET_break (0);
GNUNET_CONFIGURATION_destroy (cfg);
return GNUNET_SYSERR; return GNUNET_SYSERR;
} }
GNUNET_CONFIGURATION_destroy (cfg);
GNUNET_asprintf (&bc->bank_url, GNUNET_asprintf (&bc->bank_url,
"http://localhost:%llu/", "http://localhost:%llu/",
port); port);