taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

resolve fixmes

Browse Source
This commit is contained in:
Christian Grothoff 2020-01-20 00:21:50 +01:00
parent c87eb30e78
commit 4bf153fdb0
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
2 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/exchange/taler-exchange-aggregator.c
View File

@ -742,9 +742,6 @@ deposit_cb (void *cls,
amount_with_fee, amount_with_fee,
deposit_fee)) deposit_fee))
{ {
// FIXME(dold): Shouldn't we somehow survive this? Of course it should show up in the auditor's report,
// but due to some misconfiguration with restarts in between deposit fees could have changed.
// That's bad, but should we really refuse to continue completely?
GNUNET_log (GNUNET_ERROR_TYPE_ERROR, GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
"Fatally malformed record at row %llu over %s\n", "Fatally malformed record at row %llu over %s\n",
(unsigned long long) row_id, (unsigned long long) row_id,
@ -1283,6 +1280,7 @@ run_reserve_closures (void *cls)
now, now,
&expired_reserve_cb, &expired_reserve_cb,
&erc); &erc);
GNUNET_assert (1 >= qs);
switch (qs) switch (qs)
{ {
case GNUNET_DB_STATUS_HARD_ERROR: case GNUNET_DB_STATUS_HARD_ERROR:
@ -1314,8 +1312,6 @@ run_reserve_closures (void *cls)
task = GNUNET_SCHEDULER_add_now (&run_reserve_closures, task = GNUNET_SCHEDULER_add_now (&run_reserve_closures,
NULL); NULL);
return; return;
// FIXME(dold): shouldn't we at least GNUNET_break on the case where
// we have more than one result? Not clear that get_expired reserves can't return more results?
} }
} }
@ -1329,8 +1325,7 @@ run_reserve_closures (void *cls)
static void static void
run_aggregation (void *cls) run_aggregation (void *cls)
{ {
// FIXME(dold): This should be unsigned, as behavior on signed overflow is undefined ;-) static unsigned int swap;
static int swap;
struct TALER_EXCHANGEDB_Session *session; struct TALER_EXCHANGEDB_Session *session;
enum GNUNET_DB_QueryStatus qs; enum GNUNET_DB_QueryStatus qs;
const struct GNUNET_SCHEDULER_TaskContext *tc; const struct GNUNET_SCHEDULER_TaskContext *tc;
@ -1774,8 +1769,7 @@ wire_prepare_cb (void *cls,
NULL); NULL);
if (NULL == wpd->eh) if (NULL == wpd->eh)
{ {
// FIXME(dold): Comment below is a fixme, but without a marker! GNUNET_break (0); /* Irrecoverable */
GNUNET_break (0); /* why? how to best recover? */
db_plugin->rollback (db_plugin->cls, db_plugin->rollback (db_plugin->cls,
wpd->session); wpd->session);
global_ret = GNUNET_SYSERR; global_ret = GNUNET_SYSERR;
@ -1832,10 +1826,8 @@ run_transfers (void *cls)
session, session,
&wire_prepare_cb, &wire_prepare_cb,
NULL); NULL);
// FIXME(dold): comment below is misleading, should't that be wire_confirm_cb,
// as wire_prepare_cb is already called?
if (GNUNET_DB_STATUS_SUCCESS_ONE_RESULT == qs) if (GNUNET_DB_STATUS_SUCCESS_ONE_RESULT == qs)
return; /* continues in #wire_prepare_cb() */ return; /* continued via continuation set in #wire_prepare_cb() */
db_plugin->rollback (db_plugin->cls, db_plugin->rollback (db_plugin->cls,
session); session);
GNUNET_free (wpd); GNUNET_free (wpd);
@ -1905,7 +1897,6 @@ run (void *cls,
global_ret = 1; global_ret = 1;
return; return;
} }
// FIXME(dold): why don't we call this after 'rc' is initialized? Doesn't matter to much but ...
ctx = GNUNET_CURL_init (&GNUNET_CURL_gnunet_scheduler_reschedule, ctx = GNUNET_CURL_init (&GNUNET_CURL_gnunet_scheduler_reschedule,
&rc); &rc);
rc = GNUNET_CURL_gnunet_rc_create (ctx); rc = GNUNET_CURL_gnunet_rc_create (ctx);

5
src/exchange/test_taler_exchange_httpd_afl.sh
View File

@ -25,8 +25,9 @@
# 1) Capture all TCP traffic from 'test-auditor.sh' # 1) Capture all TCP traffic from 'test-auditor.sh'
# 2) Use 'tcpflow -e http -r $PCAP -o $OUTPUT' to get the HTTP streams # 2) Use 'tcpflow -e http -r $PCAP -o $OUTPUT' to get the HTTP streams
# 3) Remove HTTP streams unrelated to the exchange as well as the replies # 3) Remove HTTP streams unrelated to the exchange as well as the replies
# 4) Compile the exchange with AFL instrumentation # 4) Remove duplicated streams (check file size!)
# 5) Run afl-fuzz -i $OUTPUT/ -o afl-tests/ ~/bin/taler-exchange-httpd \ # 5) Compile the exchange with AFL instrumentation
# 6) Run afl-fuzz -i $OUTPUT/ -o afl-tests/ ~/bin/taler-exchange-httpd \
# -c test_taler_exchange_httpd.conf -t 1 -f @@ # -c test_taler_exchange_httpd.conf -t 1 -f @@
set -eu set -eu