-document why re-locking here is safe -- at least right now

This commit is contained in:
Christian Grothoff 2022-10-22 00:27:32 +02:00
parent 3b90f9cae2
commit 4524180ada
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC

View File

@ -3630,6 +3630,10 @@ access_withdrawals_confirm (struct TALER_FAKEBANK_Handle *h,
TALER_EC_BANK_DUPLICATE_RESERVE_PUB_SUBJECT, TALER_EC_BANK_DUPLICATE_RESERVE_PUB_SUBJECT,
NULL); NULL);
} }
/* Re-acquiring the lock and continuing to operate on 'wo'
is currently (!) acceptable because we NEVER free 'wo'
until shutdown. We may want to revise this if keeping
all withdraw operations in RAM becomes an issue... */
GNUNET_assert (0 == GNUNET_assert (0 ==
pthread_mutex_lock (&h->big_lock)); pthread_mutex_lock (&h->big_lock));
wo->confirmation_done = true; wo->confirmation_done = true;