From 3d701e8d2a39e766b8345e242c3ffb501f935a3e Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Mon, 19 Jun 2017 00:13:40 +0200 Subject: [PATCH] fix leaks and typos --- src/exchange-lib/exchange_api_refresh_link.c | 6 +++--- src/exchange/taler-exchange-httpd_db.c | 2 +- src/exchange/taler-exchange-httpd_deposit.c | 3 +++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/exchange-lib/exchange_api_refresh_link.c b/src/exchange-lib/exchange_api_refresh_link.c index 9b825138e..5b2286e6e 100644 --- a/src/exchange-lib/exchange_api_refresh_link.c +++ b/src/exchange-lib/exchange_api_refresh_link.c @@ -372,9 +372,9 @@ handle_refresh_link_finished (void *cls, */ struct TALER_EXCHANGE_RefreshLinkHandle * TALER_EXCHANGE_refresh_link (struct TALER_EXCHANGE_Handle *exchange, - const struct TALER_CoinSpendPrivateKeyP *coin_priv, - TALER_EXCHANGE_RefreshLinkCallback link_cb, - void *link_cb_cls) + const struct TALER_CoinSpendPrivateKeyP *coin_priv, + TALER_EXCHANGE_RefreshLinkCallback link_cb, + void *link_cb_cls) { struct TALER_EXCHANGE_RefreshLinkHandle *rlh; CURL *eh; diff --git a/src/exchange/taler-exchange-httpd_db.c b/src/exchange/taler-exchange-httpd_db.c index ebe19a9b5..298f6c35a 100644 --- a/src/exchange/taler-exchange-httpd_db.c +++ b/src/exchange/taler-exchange-httpd_db.c @@ -907,7 +907,7 @@ refresh_exchange_coin (struct MHD_Connection *connection, &ev_sig)) { GNUNET_log (GNUNET_ERROR_TYPE_INFO, - "Returning cashed reply for /refresh/reveal signature\n"); + "Returning cached reply for /refresh/reveal signature\n"); return ev_sig; } diff --git a/src/exchange/taler-exchange-httpd_deposit.c b/src/exchange/taler-exchange-httpd_deposit.c index d732edbb6..c9c59edef 100644 --- a/src/exchange/taler-exchange-httpd_deposit.c +++ b/src/exchange/taler-exchange-httpd_deposit.c @@ -408,6 +408,7 @@ TEH_DEPOSIT_handler_deposit (struct TEH_RequestHandler *rh, /* FIXME: #3887: if DK was revoked, we might want to give a 403 and not a 404! */ TEH_KS_release (key_state); TALER_LOG_WARNING ("Unknown denomination key in /deposit request\n"); + GNUNET_JSON_parse_free (spec); return TEH_RESPONSE_reply_arg_unknown (connection, TALER_EC_DEPOSIT_DENOMINATION_KEY_UNKNOWN, "denom_pub"); @@ -420,6 +421,7 @@ TEH_DEPOSIT_handler_deposit (struct TEH_RequestHandler *rh, { TALER_LOG_WARNING ("Invalid coin passed for /deposit\n"); TEH_KS_release (key_state); + GNUNET_JSON_parse_free (spec); return TEH_RESPONSE_reply_signature_invalid (connection, TALER_EC_DEPOSIT_DENOMINATION_SIGNATURE_INVALID, "ub_sig"); @@ -432,6 +434,7 @@ TEH_DEPOSIT_handler_deposit (struct TEH_RequestHandler *rh, &deposit.amount_with_fee)) { GNUNET_break_op (0); + GNUNET_JSON_parse_free (spec); return TEH_RESPONSE_reply_external_error (connection, TALER_EC_DEPOSIT_NEGATIVE_VALUE_AFTER_FEE, "deposited amount smaller than depositing fee");