-resolving fixmes or annotating to bug tracker notes

This commit is contained in:
Christian Grothoff 2015-03-24 00:00:16 +01:00
parent f73071bc62
commit 38fae8edf2
4 changed files with 4 additions and 5 deletions

View File

@ -440,7 +440,6 @@ TALER_MINT_db_execute_withdraw_sign (struct MHD_Connection *connection,
return TALER_MINT_reply_internal_error (connection,
"Internal error");
}
/* FIXME: this signature is still blinded, bad name... */
collectable.sig.rsa_signature = sig;
collectable.denom_pub = *denomination_pub;
collectable.reserve_pub = *reserve;
@ -730,7 +729,7 @@ TALER_MINT_db_execute_refresh_melt (struct MHD_Connection *connection,
refresh_session.session_hash = *melt_hash;
refresh_session.num_oldcoins = coin_count;
refresh_session.num_newcoins = num_new_denoms;
refresh_session.kappa = KAPPA; // FIXME...
refresh_session.kappa = KAPPA; // FIXME... (#3711)
refresh_session.noreveal_index
= GNUNET_CRYPTO_random_u32 (GNUNET_CRYPTO_QUALITY_STRONG,
refresh_session.kappa);

View File

@ -470,7 +470,7 @@ handle_refresh_melt_json (struct MHD_Connection *connection,
coin_count = json_array_size (melt_coins);
/* FIXME: make 'struct TALER_CoinPublicInfo' part of `struct MeltDetails`
and combine these two arrays/arguments! */
and combine these two arrays/arguments! (#3726) */
coin_public_infos = GNUNET_malloc (coin_count *
sizeof (struct TALER_CoinPublicInfo));
coin_melt_details = GNUNET_malloc (coin_count *

View File

@ -403,7 +403,7 @@ get_anchor (const char *dir,
/* FIXME: this check is a bit dubious, as 'now'
may be way into the future if we want to generate
many keys... */
many keys... #3727*/
if ((GNUNET_TIME_absolute_add (*anchor,
duration)).abs_value_us < now.abs_value_us)
{

View File

@ -184,7 +184,7 @@ reservemod_add (struct TALER_Amount denom)
PQresultErrorMessage (result));
return GNUNET_SYSERR;
}
/* FIXME: strcmp!? There must be an API that returns an int! */
/* Yes, for historic reasons libpq returns a 'const char *'... */
if (0 != strcmp ("1",
PQcmdTuples (result)))
{