taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

redefining/adding bank error codes

Browse Source
This commit is contained in:
Marcello Stanisci 2017-12-22 21:22:57 +01:00
parent 8021e7064d
commit 346c351e5f
No known key found for this signature in database
GPG Key ID: 8D526861953F4C0F
2 changed files with 51 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bank-lib/fakebank.c
View File

@ -613,7 +613,7 @@ handle_reject (struct TALER_FAKEBANK_Handle *h,
if (GNUNET_OK != found) if (GNUNET_OK != found)
return create_bank_error (connection, return create_bank_error (connection,
MHD_HTTP_NOT_FOUND, MHD_HTTP_NOT_FOUND,
TALER_EC_BANK_REJECT_NOT_FOUND, TALER_EC_BANK_REJECT_TRANSACTION_NOT_FOUND,
"transaction unknown"); "transaction unknown");
/* finally build regular response */ /* finally build regular response */
resp = MHD_create_response_from_buffer (0, resp = MHD_create_response_from_buffer (0,

83
src/include/taler_error_codes.h
View File

@ -1503,67 +1503,84 @@ enum TALER_ErrorCode
/* *************** Taler BANK/FAKEBANK error codes *************** */ /* *************** Taler BANK/FAKEBANK error codes *************** */
/** /**
* Authentication failed for an unspecified request. * The request cannot be served because the client failed to
* To return when the view name is not available, or * login. To be returned along HTTP 401 Unauthorized.
* no specific error code is defined yet.
*/ */
TALER_EC_BANK_NOT_AUTHORIZED = 5000, TALER_EC_BANK_REJECT_LOGIN_FAILED = 5312,
/** /**
* The bank could not find the bank account specified * The transaction cannot be rejected becasue it does not exist
* in the request. Returned with a status code of MHD_HTTP_NOT_FOUND. * at the bank. To be returned along HTTP 404 Not Found.
*/ */
TALER_EC_BANK_UNKNOWN_ACCOUNT = 5001, TALER_EC_BANK_REJECT_TRANSACTION_NOT_FOUND = 5301,
/** /**
* Authentication failed for the /admin/add/incoming request. * The client does not own the account credited by the transaction
* Returned with a status code of MHD_HTTP_FORBIDDEN. * which is to be rejected, so it has no rights do reject it. To be
* returned along HTTP 403 Forbidden.
*/ */
TALER_EC_BANK_TRANSFER_NOT_AUHTORIZED = 5100, TALER_EC_BANK_REJECT_NO_RIGHTS = 5313,
/** /**
* The wire transfer cannot be done because the debitor would * The POSTed JSON at /reject was invalid. To be returned along
* reach a unallowed debit. * HTTP 400 Bad Request.
*/ */
TALER_EC_BANK_TRANSFER_DEBIT = 5101, TALER_EC_BANK_REJECT_JSON_INVALID = 5306,
/** /**
* The wire transfer cannot be done because the credit and * A URL parameter for /history was missing. To be returned along
* debit account are the same. * HTTP 400 Bad Request.
*/ */
TALER_EC_BANK_TRANSFER_SAME_ACCOUNT = 5102, TALER_EC_BANK_HISTORY_PARAMETER_MISSING = 5208,
/** /**
* Authentication failed for the /history request. * A URL parameter for /history was malformed. To be returned along
* Returned with a status code of MHD_HTTP_FORBIDDEN. * HTTP 400 Bad Request.
*/ */
TALER_EC_BANK_HISTORY_NOT_AUHTORIZED = 5200, TALER_EC_BANK_HISTORY_PARAMETER_MALFORMED = 5209,
/** /**
* The bank library had trouble obtaining a valid * The client failed to login for /history. To be returned along
* HTTP response. * HTTP 401 Unauthorized.
* Returned with a status code of 0.
*/ */
TALER_EC_BANK_HISTORY_HTTP_FAILURE = 5201, TALER_EC_BANK_HISTORY_LOGIN_FAILED = 5212,
/** /**
* The bank could not find the wire transfer that was supposed to * The bank had trouble obtaining a valid HTTP response. To be returned
* be rejected. * along status code 0.
* Returned with a status code of MHD_HTTP_NOT_FOUND.
*/ */
TALER_EC_BANK_REJECT_NOT_FOUND = 5300, TALER_EC_BANK_HISTORY_HTTP_FAILURE = 5213,
/** /**
* Authentication failed for the /reject request. * The debit account for /admin/add/incoming is not known to the
* Returned with a status code of MHD_HTTP_FORBIDDEN. * bank. To be returned along HTTP 404 Not Found.
*/ */
TALER_EC_BANK_REJECT_NOT_AUTHORIZED = 5301, TALER_EC_BANK_ADD_INCOMING_UNKNOWN_ACCOUNT = 5100,
/** /**
* The client wants to reject a transaction where they are * The client specified the same bank account for both the credit
* not the _credit_ party, impossible! * and the debit account. The bank will not accomplish this operation.
* To be returned along HTTP 403 Forbidden.
*/ */
TALER_EC_BANK_REJECT_NO_RIGHTS = 5302, TALER_EC_BANK_ADD_INCOMING_SAME_ACCOUNT = 5102,
/**
* The operation would put the client in a debit situation which is
* forbidden to them. To return along HTTP 403 Forbidden.
*/
TALER_EC_BANK_ADD_INCOMING_UNALLOWED_DEBIT = 5103,
/**
* The client POSTed an invalid JSON. To be returned along HTTP
* 400 Bad Request.
*/
TALER_EC_BANK_ADD_INCOMING_JSON_INVALID = 5106,
/**
* The client failed to login for /admin/add/incoming. To be returned
* along HTTP 401 Unauthorized.
*/
TALER_EC_BANK_ADD_INCOMING_LOGIN_FAILED = 5112,
/** /**
* End of error code range. * End of error code range.