taler/exchange
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

TODO is already done

Browse Source
This commit is contained in:
Christian Grothoff 2020-01-17 20:02:25 +01:00
parent 11c5283711
commit 23cc4a521f
No known key found for this signature in database
GPG Key ID: 939E6BE1E29FC3CC
2 changed files with 33 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/auditor/taler-auditor.c
View File

@ -1805,7 +1805,7 @@ verify_reserve_balance (void *cls,
if ( (0ULL == balance.value) &&
(0U == balance.fraction) )
{
/* TODO: balance is zero, drop reserve details (and then do not update/insert) */
/* balance is zero, drop reserve details (and then do not update/insert) */
if (rs->had_ri)
{
GNUNET_log (GNUNET_ERROR_TYPE_INFO,

38
src/lib/exchange_api_common.c
View File

@ -47,6 +47,7 @@ TALER_EXCHANGE_verify_coin_history (const struct
{
size_t len;
struct TALER_Amount rtotal;
struct TALER_Amount fee;
if (NULL == history)
{
@ -135,8 +136,16 @@ TALER_EXCHANGE_verify_coin_history (const struct
GNUNET_break_op (0);
return GNUNET_SYSERR;
}
/* TODO: check that deposit fee and coin value match
our expectations from /keys! */
/* check that deposit fee matches our expectations from /keys! */
TALER_amount_ntoh (&fee,
&dr.deposit_fee);
if (0 !=
TALER_amount_cmp (&fee,
&dk->fee_deposit))
{
GNUNET_break_op (0);
return GNUNET_SYSERR;
}
add = GNUNET_YES;
}
else if (0 == strcasecmp (type,
@ -176,8 +185,16 @@ TALER_EXCHANGE_verify_coin_history (const struct
GNUNET_break_op (0);
return GNUNET_SYSERR;
}
/* TODO: check that deposit fee and coin value match
our expectations from /keys! */
/* check that melt fee matches our expectations from /keys! */
TALER_amount_ntoh (&fee,
&rm.melt_fee);
if (0 !=
TALER_amount_cmp (&fee,
&dk->fee_refresh))
{
GNUNET_break_op (0);
return GNUNET_SYSERR;
}
add = GNUNET_YES;
}
else if (0 == strcasecmp (type,
@ -228,8 +245,17 @@ TALER_EXCHANGE_verify_coin_history (const struct
(an auditor ought to check, though). Then again, we similarly
had no reason to check the merchant's signature (other than a
well-formendess check). *///
/* TODO: check that deposit fee and coin value match
our expectations from /keys! *///
/* check that refund fee matches our expectations from /keys! */
TALER_amount_ntoh (&fee,
&rr.refund_fee);
if (0 !=
TALER_amount_cmp (&fee,
&dk->fee_refund))
{
GNUNET_break_op (0);
return GNUNET_SYSERR;
}
add = GNUNET_NO;
}
else if (0 == strcasecmp (type,