doxygen fixes

contrib/gana

@@ -1 +1 @@
-Subproject commit 0b778cdac372d0b75f3b64501a15a21c9c57f36e
+Subproject commit 18a39c29726860af58800a28454446154b89832b

contrib/gnunet.tag

@@ -158,17 +158,41 @@
       <anchorfile>gnunet_pq_lib.h</anchorfile>
       <arglist>(const struct GNUNET_TIME_AbsoluteNBO *x)</arglist>
     </member>
+    <member kind="function">
+      <type>struct GNUNET_SQ_QueryParam</type>
+      <name>GNUNET_SQ_query_param_absolute_time</name>
+      <anchorfile>gnunet_sq_lib.h</anchorfile>
+      <arglist>(const struct GNUNET_TIME_Absolute *x)</arglist>
+    </member>
+    <member kind="function">
+      <type>struct GNUNET_SQ_QueryParam</type>
+      <name>GNUNET_PQ_query_param_absolute_time_nbo</name>
+      <anchorfile>gnunet_sq_lib.h</anchorfile>
+      <arglist>(const struct GNUNET_TIME_AbsoluteNBO *x)</arglist>
+    </member>
     <member kind="define">
       <type>#define</type>
       <name>GNUNET_PQ_query_param_end</name>
       <anchorfile>gnunet_pq_lib.h</anchorfile>
       <arglist></arglist>
     </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_SQ_query_param_end</name>
+      <anchorfile>gnunet_sq_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
     <member kind="typedef">
       <type>int</type>
       <name>GNUNET_PQ_ResultConverter</name>
       <anchorfile>gnunet_pq_lib.h</anchorfile>
       <arglist>)(void *cls, PGresult *result, int row, const char *fname, size_t *dst_size, void *dst)</arglist>
     </member>
+    <member kind="typedef">
+      <type>int</type>
+      <name>GNUNET_SQ_ResultConverter</name>
+      <anchorfile>gnunet_sq_lib.h</anchorfile>
+      <arglist>)(void *cls, sqlite3_stmt *result, unsigned int column, size_t *dst_size, void *dst)</arglist>
+    </member>
   </compound>
 </tagfile>

doc/doxygen/taler.doxy

@@ -266,12 +266,11 @@ TAGFILES               = ../../contrib/gnunet.tag ../../contrib/microhttpd.tag
 GENERATE_TAGFILE       = taler-exchange.tag
 ALLEXTERNALS           = NO
 EXTERNAL_GROUPS        = YES
-PERL_PATH              = /usr/bin/perl
+
 #---------------------------------------------------------------------------
 # Configuration options related to the dot tool
 #---------------------------------------------------------------------------
 CLASS_DIAGRAMS         = YES
-MSCGEN_PATH            =
 HIDE_UNDOC_RELATIONS   = YES
 HAVE_DOT               = YES
 CLASS_GRAPH            = NO

src/auditor/report-lib.c

@@ -583,7 +583,7 @@ TALER_ARL_amount_subtract_ (struct TALER_Amount *diff,
  * @param filename where is the addition called
  * @param functionname name of the function where the addition is called
  * @param line line number of the addition
- * @return #TALER_ARL_SR_NEGATIVE if the result was negative (and @a diff is now invalid),
+ * @return #TALER_ARL_SR_INVALID_NEGATIVE if the result was negative (and @a diff is now invalid),
  *         #TALER_ARL_SR_ZERO if the result was zero,
  *         #TALER_ARL_SR_POSITIVE if the result is positive
  */

src/auditor/report-lib.h

@@ -258,7 +258,7 @@ enum TALER_ARL_SubtractionResult
  * @param filename where is the addition called
  * @param functionname name of the function where the addition is called
  * @param line line number of the addition
- * @return #TALER_ARL_SR_NEGATIVE if the result was negative (and @a diff is now invalid),
+ * @return #TALER_ARL_SR_INVALID_NEGATIVE if the result was negative (and @a diff is now invalid),
  *         #TALER_ARL_SR_ZERO if the result was zero,
  *         #TALER_ARL_SR_POSITIVE if the result is positive
  */
@@ -280,7 +280,7 @@ TALER_ARL_amount_subtract_neg_ (struct TALER_Amount *diff,
  * @param[out] diff where to store (@a a1 - @a a2)
  * @param a1 amount to subtract from
  * @param a2 amount to subtract
- * @return #TALER_ARL_SR_NEGATIVE if the result was negative (and @a diff is now invalid),
+ * @return #TALER_ARL_SR_INVALID_NEGATIVE if the result was negative (and @a diff is now invalid),
  *         #TALER_ARL_SR_ZERO if the result was zero,
  *         #TALER_ARL_SR_POSITIVE if the result is positive
  */

src/auditor/taler-helper-auditor-deposits.c

@@ -96,7 +96,7 @@ struct DepositConfirmationContext
  * @param cls our `struct DepositConfirmationContext`
  * @param serial_id row of the @a dc in the database
  * @param dc the deposit confirmation we know
- * @return #GNUNET_OK to continue to iterate, #GNUNET_SYSERROR to stop iterating
+ * @return #GNUNET_OK to continue to iterate, #GNUNET_SYSERR to stop iterating
  */
 static int
 test_dc (void *cls,

src/bank-lib/taler-wire-gateway-client.c

@@ -14,7 +14,7 @@
   TALER; see the file COPYING.  If not, see <http://www.gnu.org/licenses/>
 */
 /**
- * @file taler-bank-transfer.c
+ * @file taler-wire-gateway-client.c
  * @brief Execute wire transfer.
  * @author Christian Grothoff
  */

src/include/taler_auditor_service.h

@@ -234,7 +234,7 @@ typedef void
  * @param auditor the auditor handle; the auditor must be ready to operate
  * @param h_wire hash of merchant wire details
  * @param h_contract_terms hash of the contact of the merchant with the customer (further details are never disclosed to the auditor)
- * @param timestamp timestamp when the contract was finalized, must not be too far in the future
+ * @param exchange_timestamp timestamp when the contract was finalized, must not be too far in the future
  * @param refund_deadline date until which the merchant can issue a refund to the customer via the auditor (can be zero if refunds are not allowed); must not be after the @a wire_deadline
  * @param amount_without_fee the amount confirmed to be wired by the exchange to the merchant
  * @param coin_pub coin’s public key

src/include/taler_signatures.h

@@ -1338,26 +1338,6 @@ struct TALER_ReserveCloseConfirmationPS
 };
 
 
-/**
- * Used by the merchant to confirm with a signature that the refund has
- * been successfully done. Even though the frontend doesn't usually do crypto,
- * this signature may turn useful in court.
- */
-struct TALER_MerchantRefundConfirmationPS
-{
-  /**
-   * Set to #TALER_SIGNATURE_MERCHANT_REFUND_OK.
-   */
-  struct GNUNET_CRYPTO_EccSignaturePurpose purpose;
-
-  /**
-   * Hashed order id; in case frontend wants to check it.
-   * Hashed without the 0-termination.
-   */
-  struct GNUNET_HashCode h_order_id GNUNET_PACKED;
-
-};
-
 /**
  * Used by the merchant to confirm to the frontend that
  * the user did a payment replay with the current browser session.

src/include/taler_testing_lib.h

@@ -844,8 +844,7 @@ TALER_TESTING_run_bank (const char *config_filename,
  * responsible to create the exchange EBICS subscriber at
  * the nexus.
  *
- * @param bank_url base URL of the bank, used by `wget' to check
- *        that the bank was started right.
+ * @param bc bank configuration of the bank
  * @return the process, or NULL if the process could not
  *         be started.
  */

src/lib/exchange_api_withdraw2.c

@@ -347,11 +347,8 @@ handle_reserve_withdraw_finished (void *cls,
  * same arguments in case of failures.
  *
  * @param exchange the exchange handle; the exchange must be ready to operate
- * @param pk kind of coin to create
- * @param reserve_sig signature from the reserve authorizing the withdrawal
- * @param reserve_pub public key of the reserve to withdraw from
- * @param ps secrets of the planchet
- *        caller must have committed this value to disk before the call (with @a pk)
+ * @param pd planchet details of the planchet to withdraw
+ * @param reserve_priv private key of the reserve to withdraw from
  * @param res_cb the callback to call when the final result for this request is available
  * @param res_cb_cls closure for @a res_cb
  * @return NULL

src/testing/testing_api_helpers_bank.c

@@ -106,6 +106,7 @@ TALER_TESTING_has_in_name (const char *prog,
  * bank" function to do such tasks.  This function is also
  * responsible to create the exchange user at Nexus.
  *
+ * @param bc bank configuration of the bank
  * @return the pair of both service handles.  In case of
  *         errors, each element of the pair will be set to NULL.
  */