add guard logic to check sizeof(value) is sufficient (should be -- size is 20, needed are 5, but still the new code is strictly safer even if slower)

2019-06-03 11:20:47 +02:00 · 2019-06-03 11:20:47 +02:00 · 01e8e930dc
commit 01e8e930dc
parent 91ef87a804
1 changed files with 6 additions and 4 deletions
--- a/src/bank-lib/bank_api_history.c
+++ b/src/bank-lib/bank_api_history.c
@ -366,10 +366,12 @@ conv_cancel (enum TALER_BANK_Direction direction)

  if (TALER_BANK_DIRECTION_CANCEL ==
      (TALER_BANK_DIRECTION_CANCEL & direction))
-    strcpy (&ret.value[0],
+    GNUNET_snprintf (ret.value,
+                     sizeof (ret.value),
                     "show");
  else
-    strcpy (&ret.value[0],
+    GNUNET_snprintf (ret.value,
+                     sizeof (ret.value),
                     "omit");
  return ret;
 }